Readme update - url fix

README.md

@@ -9,7 +9,7 @@ DnsClient.NET is a simple yet very powerful and high performance open source lib
 
 ## Usage
 
-See http://dnsclient.michaco.net for more details and documentation.
+See [the DnsClient site][dnsclient] for more details and documentation.
 
 The following example instantiates a new `LookupClient` to query some IP address.
 
@@ -57,6 +57,7 @@ Just clone the repository and open the solution in Visual Studio 2019.
 ## Examples
 
 * See [MiniDig](https://github.com/MichaCo/DnsClient.NET/tree/dev/samples/MiniDig)'s readme for what this example command line tool can do.
-* More documentation and a simple query window on http://dnsclient.michaco.net
+* [More documentation and examples][dnsclient]
 * The [Samples](https://github.com/MichaCo/DnsClient.NET.Samples) repository (there might be more in the future).
 
+[dnsclient]:https://dnsclient.michaco.net

samples/MiniDig/Program.cs

@@ -9,7 +9,7 @@ public class Program
     {
         public static async Task<int> Main(string[] args)
         {
-            DnsClient.Tracing.Source.Switch.Level = SourceLevels.Information;
+            DnsClient.Tracing.Source.Switch.Level = SourceLevels.Warning;
             DnsClient.Tracing.Source.Listeners.Add(new ConsoleTraceListener());
 
             var app = new CommandLineApplication(throwOnUnexpectedArg: true);

src/DnsClient/DnsQueryExtensions.cs

@@ -738,9 +738,9 @@ public static ServiceHostEntry[] ResolveServiceProcessResult(IDnsQueryResponse r
     }
 
     /// <summary>
-    /// Extends <see cref="IPHostEntry"/> by the <see cref="ServiceHostEntry.Port"/> property.
+    /// Extends <see cref="IPHostEntry"/> by the <see cref="Port"/> property.
     /// </summary>
-    /// <seealso cref="System.Net.IPHostEntry" />
+    /// <seealso cref="IPHostEntry" />
     public class ServiceHostEntry : IPHostEntry
     {
         /// <summary>

src/DnsClient/DnsQueryOptions.cs

@@ -143,7 +143,7 @@ public class DnsQueryOptions
         /// <summary>
         /// Gets or sets the request timeout in milliseconds. <see cref="Timeout"/> is used for limiting the connection and request time for one operation.
         /// Timeout must be greater than zero and less than <see cref="int.MaxValue"/>.
-        /// If <see cref="System.Threading.Timeout.InfiniteTimeSpan"/> (or -1) is used, no timeout will be applied.
+        /// If <see cref="Timeout.InfiniteTimeSpan"/> (or -1) is used, no timeout will be applied.
         /// Default is 5 seconds.
         /// </summary>
         /// <remarks>
@@ -579,7 +579,7 @@ public class DnsQuerySettings : IEquatable<DnsQuerySettings>
         /// <summary>
         /// Gets the request timeout in milliseconds. <see cref="Timeout"/> is used for limiting the connection and request time for one operation.
         /// Timeout must be greater than zero and less than <see cref="int.MaxValue"/>.
-        /// If <see cref="System.Threading.Timeout.InfiniteTimeSpan"/> (or -1) is used, no timeout will be applied.
+        /// If <see cref="Timeout.InfiniteTimeSpan"/> (or -1) is used, no timeout will be applied.
         /// Default is 5 seconds.
         /// </summary>
         /// <remarks>

src/DnsClient/DnsResponseCode.cs

@@ -273,7 +273,7 @@ public enum DnsResponseCode
     /// <summary>
     /// A DnsClient specific exception transporting additional information about the query causing this exception.
     /// </summary>
-    /// <seealso cref="System.Exception" />
+    /// <seealso cref="Exception" />
 #if !NETSTANDARD1_3
     [Serializable]
 #endif

src/DnsClient/Internal/ILogger.cs

@@ -12,4 +12,4 @@ public interface ILogger
     }
 }
 
-#pragma warning restore CS1591 // Missing XML comment for publicly visible type or member
+#pragma warning restore CS1591 // Missing XML comment for publicly visible type or member

src/DnsClient/Internal/ILoggerFactory.cs

@@ -8,4 +8,4 @@ public interface ILoggerFactory
     }
 }
 
-#pragma warning restore CS1591 // Missing XML comment for publicly visible type or member
+#pragma warning restore CS1591 // Missing XML comment for publicly visible type or member

src/DnsClient/Internal/LogLevel.cs

@@ -14,4 +14,4 @@ public enum LogLevel
     }
 }
 
-#pragma warning restore CS1591 // Missing XML comment for publicly visible type or member
+#pragma warning restore CS1591 // Missing XML comment for publicly visible type or member

src/DnsClient/Internal/LoggerExtensions.cs

@@ -143,4 +143,4 @@ public static void Log(this ILogger logger, LogLevel logLevel, Exception excepti
     }
 }
 
-#pragma warning restore CS1591 // Missing XML comment for publicly visible type or member
+#pragma warning restore CS1591 // Missing XML comment for publicly visible type or member

src/DnsClient/Internal/NullLoggerFactory.cs

@@ -21,4 +21,4 @@ public void Log(LogLevel logLevel, int eventId, Exception exception, string mess
             }
         }
     }
-}
+}

src/DnsClient/Internal/StringBuilderObjectPool.cs

@@ -170,7 +170,7 @@ internal abstract class ObjectPoolProvider
     {
         public ObjectPool<T> Create<T>() where T : class, new()
         {
-            return Create<T>(new DefaultPooledObjectPolicy<T>());
+            return Create(new DefaultPooledObjectPolicy<T>());
         }
 
         public abstract ObjectPool<T> Create<T>(IPooledObjectPolicy<T> policy) where T : class;
@@ -210,7 +210,7 @@ internal static class ObjectPoolProviderExtensions
     {
         public static ObjectPool<StringBuilder> CreateStringBuilderPool(this ObjectPoolProvider provider)
         {
-            return provider.Create<StringBuilder>(new StringBuilderPooledObjectPolicy());
+            return provider.Create(new StringBuilderPooledObjectPolicy());
         }
 
         public static ObjectPool<StringBuilder> CreateStringBuilderPool(
@@ -224,9 +224,9 @@ public static ObjectPool<StringBuilder> CreateStringBuilderPool(this ObjectPoolP
                 MaximumRetainedCapacity = maximumRetainedCapacity,
             };
 
-            return provider.Create<StringBuilder>(policy);
+            return provider.Create(policy);
         }
     }
 }
 
-#pragma warning restore CS1591 // Missing XML comment for publicly visible type or member
+#pragma warning restore CS1591 // Missing XML comment for publicly visible type or member

src/DnsClient/Interop/DisposableIntPtr.cs

@@ -36,4 +36,4 @@ public void Dispose()
             Marshal.FreeHGlobal(_ptr);
         }
     }
-}
+}

src/DnsClient/IpAddressExtensions.cs

@@ -17,8 +17,8 @@ public static class IpAddressExtensions
         /// </summary>
         /// <param name="ip">The address to translate.</param>
         /// <returns>The arpa representation of the address.</returns>
-        /// <seealso cref="DnsClient.IDnsQuery.QueryReverse(IPAddress)"/>
-        /// <seealso cref="DnsClient.IDnsQuery.QueryReverseAsync(IPAddress, Threading.CancellationToken)"/>
+        /// <seealso cref="IDnsQuery.QueryReverse(IPAddress)"/>
+        /// <seealso cref="IDnsQuery.QueryReverseAsync(IPAddress, Threading.CancellationToken)"/>
         /// <seealso href="https://en.wikipedia.org/wiki/.arpa"/>
         public static string GetArpaName(this IPAddress ip)
         {

src/DnsClient/Protocol/AddressRecord.cs

@@ -25,7 +25,7 @@ public class AddressRecord : DnsResourceRecord
         /// <param name="info">The information.</param>
         /// <param name="address">The address.</param>
         /// <exception cref="ArgumentNullException">If <paramref name="info"/> is null.</exception>
-        /// <exception cref="System.ArgumentNullException">If <paramref name="address"/> or <paramref name="info"/> is null</exception>
+        /// <exception cref="ArgumentNullException">If <paramref name="address"/> or <paramref name="info"/> is null</exception>
         public AddressRecord(ResourceRecordInfo info, IPAddress address)
             : base(info)
         {
@@ -37,4 +37,4 @@ private protected override string RecordToString()
             return Address.ToString();
         }
     }
-}
+}

src/DnsClient/Protocol/AfsDbRecord.cs

@@ -52,7 +52,7 @@ public class AfsDbRecord : DnsResourceRecord
         /// <param name="info">The information.</param>
         /// <param name="type">The type.</param>
         /// <param name="name">The name.</param>
-        /// <exception cref="System.ArgumentNullException">If <paramref name="info"/> or <paramref name="name"/> is null.</exception>
+        /// <exception cref="ArgumentNullException">If <paramref name="info"/> or <paramref name="name"/> is null.</exception>
         public AfsDbRecord(ResourceRecordInfo info, AfsType type, DnsString name) : base(info)
         {
             SubType = type;
@@ -80,4 +80,4 @@ public enum AfsType
         /// </summary>
         Dce = 2
     }
-}
+}

src/DnsClient/Protocol/CNameRecord.cs

@@ -41,7 +41,7 @@ public class CNameRecord : DnsResourceRecord
         /// </summary>
         /// <param name="info">The information.</param>
         /// <param name="canonicalName">The canonical name.</param>
-        /// <exception cref="System.ArgumentNullException">If <paramref name="canonicalName"/> or <paramref name="info"/> is null.</exception>
+        /// <exception cref="ArgumentNullException">If <paramref name="canonicalName"/> or <paramref name="info"/> is null.</exception>
         public CNameRecord(ResourceRecordInfo info, DnsString canonicalName)
             : base(info)
         {
@@ -53,4 +53,4 @@ private protected override string RecordToString()
             return CanonicalName.Value;
         }
     }
-}
+}

src/DnsClient/Protocol/CaaRecord.cs

@@ -115,7 +115,7 @@ public class CaaRecord : DnsResourceRecord
         /// <param name="flags">The flags.</param>
         /// <param name="tag">The tag.</param>
         /// <param name="value">The value.</param>
-        /// <exception cref="System.ArgumentNullException">If <paramref name="info"/> or <paramref name="tag"/> or <paramref name="value"/> is null.</exception>
+        /// <exception cref="ArgumentNullException">If <paramref name="info"/> or <paramref name="tag"/> or <paramref name="value"/> is null.</exception>
         public CaaRecord(ResourceRecordInfo info, byte flags, string tag, string value) : base(info)
         {
             Flags = flags;
@@ -128,4 +128,4 @@ private protected override string RecordToString()
             return $"{Flags} {Tag} \"{Value}\"";
         }
     }
-}
+}

src/DnsClient/Protocol/DnsResourceRecord.cs

@@ -5,7 +5,7 @@ namespace DnsClient.Protocol
     /// <summary>
     /// Base class for all resource records.
     /// </summary>
-    /// <seealso cref="DnsClient.Protocol.ResourceRecordInfo" />
+    /// <seealso cref="ResourceRecordInfo" />
     public abstract class DnsResourceRecord : ResourceRecordInfo
     {
         /// <summary>
@@ -128,7 +128,7 @@ public ResourceRecordInfo(string domainName, ResourceRecordType recordType, Quer
         /// <param name="recordClass">The record class.</param>
         /// <param name="timeToLive">The time to live.</param>
         /// <param name="rawDataLength">Length of the raw data.</param>
-        /// <exception cref="System.ArgumentNullException">If <paramref name="domainName" /> is null or empty.</exception>
+        /// <exception cref="ArgumentNullException">If <paramref name="domainName" /> is null or empty.</exception>
         public ResourceRecordInfo(DnsString domainName, ResourceRecordType recordType, QueryClass recordClass, int timeToLive, int rawDataLength)
         {
             DomainName = domainName ?? throw new ArgumentNullException(nameof(domainName));

src/DnsClient/Protocol/EmptyRecord.cs

@@ -4,7 +4,7 @@
     /// A <see cref="DnsResourceRecord"/> not representing any specific resource record.
     /// Used if unsupported <see cref="ResourceRecordType"/>s are found in the result.
     /// </summary>
-    /// <seealso cref="DnsClient.Protocol.DnsResourceRecord" />
+    /// <seealso cref="DnsResourceRecord" />
     public class EmptyRecord : DnsResourceRecord
     {
         /// <summary>

src/DnsClient/Protocol/HinfoRecord.cs

@@ -48,7 +48,7 @@ public class HInfoRecord : DnsResourceRecord
         /// <param name="info">The information.</param>
         /// <param name="cpu">The CPU.</param>
         /// <param name="os">The OS.</param>
-        /// <exception cref="System.ArgumentNullException">If <paramref name="info"/> is null.</exception>
+        /// <exception cref="ArgumentNullException">If <paramref name="info"/> is null.</exception>
         public HInfoRecord(ResourceRecordInfo info, string cpu, string os)
             : base(info)
         {

src/DnsClient/Protocol/MXRecord.cs

@@ -53,7 +53,7 @@ public class MxRecord : DnsResourceRecord
         /// <param name="info">The information.</param>
         /// <param name="preference">The preference.</param>
         /// <param name="domainName">Name of the domain.</param>
-        /// <exception cref="System.ArgumentNullException">If <paramref name="domainName"/> or <paramref name="info"/> is null.</exception>
+        /// <exception cref="ArgumentNullException">If <paramref name="domainName"/> or <paramref name="info"/> is null.</exception>
         public MxRecord(ResourceRecordInfo info, ushort preference, DnsString domainName)
             : base(info)
         {

src/DnsClient/Protocol/MbRecord.cs

@@ -37,7 +37,7 @@ public class MbRecord : DnsResourceRecord
         /// </summary>
         /// <param name="info">The information.</param>
         /// <param name="domainName">The domain name.</param>
-        /// <exception cref="System.ArgumentNullException">If <paramref name="domainName"/> or <paramref name="info"/> is null.</exception>
+        /// <exception cref="ArgumentNullException">If <paramref name="domainName"/> or <paramref name="info"/> is null.</exception>
         public MbRecord(ResourceRecordInfo info, DnsString domainName)
             : base(info)
         {

src/DnsClient/Protocol/MgRecord.cs

@@ -39,7 +39,7 @@ public class MgRecord : DnsResourceRecord
         /// </summary>
         /// <param name="info">The information.</param>
         /// <param name="domainName">The domain name.</param>
-        /// <exception cref="System.ArgumentNullException">If <paramref name="domainName"/> or <paramref name="info"/> is null.</exception>
+        /// <exception cref="ArgumentNullException">If <paramref name="domainName"/> or <paramref name="info"/> is null.</exception>
         public MgRecord(ResourceRecordInfo info, DnsString domainName)
             : base(info)
         {

src/DnsClient/Protocol/MrRecord.cs

@@ -40,7 +40,7 @@ public class MrRecord : DnsResourceRecord
         /// </summary>
         /// <param name="info">The information.</param>
         /// <param name="name">The domain name.</param>
-        /// <exception cref="System.ArgumentNullException">If <paramref name="name"/> or <paramref name="info"/> is null.</exception>
+        /// <exception cref="ArgumentNullException">If <paramref name="name"/> or <paramref name="info"/> is null.</exception>
         public MrRecord(ResourceRecordInfo info, DnsString name)
             : base(info)
         {

src/DnsClient/Protocol/NsRecord.cs

@@ -47,7 +47,7 @@ public class NsRecord : DnsResourceRecord
         /// </summary>
         /// <param name="info">The information.</param>
         /// <param name="name">The name.</param>
-        /// <exception cref="System.ArgumentNullException">If <paramref name="name"/> or <paramref name="info"/> is null.</exception>
+        /// <exception cref="ArgumentNullException">If <paramref name="name"/> or <paramref name="info"/> is null.</exception>
         public NsRecord(ResourceRecordInfo info, DnsString name)
             : base(info)
         {

src/DnsClient/Protocol/Options/OptRecord.cs

@@ -144,4 +144,4 @@ private protected override string RecordToString()
         }
     }
 }
-#pragma warning restore CS1591 // Missing XML comment for publicly visible type or member
+#pragma warning restore CS1591 // Missing XML comment for publicly visible type or member

src/DnsClient/Protocol/PtrRecord.cs

@@ -26,7 +26,7 @@ namespace DnsClient.Protocol
     /// A <see cref="DnsResourceRecord"/> representing a pointer. These RRs are used
     /// in special domains to point to some other location in the domain space.
     /// </summary>
-    /// <seealso cref="DnsClient.Protocol.DnsResourceRecord" />
+    /// <seealso cref="DnsResourceRecord" />
     /// <seealso href="https://tools.ietf.org/html/rfc1035#section-3.3.12">RFC 1035</seealso>
     public class PtrRecord : DnsResourceRecord
     {
@@ -43,7 +43,7 @@ public class PtrRecord : DnsResourceRecord
         /// </summary>
         /// <param name="info">The information.</param>
         /// <param name="ptrDomainName">The domain name.</param>
-        /// <exception cref="System.ArgumentNullException">If <paramref name="info"/> or <paramref name="ptrDomainName"/> is null.</exception>
+        /// <exception cref="ArgumentNullException">If <paramref name="info"/> or <paramref name="ptrDomainName"/> is null.</exception>
         public PtrRecord(ResourceRecordInfo info, DnsString ptrDomainName)
             : base(info)
         {

src/DnsClient/Protocol/RpRecord.cs

@@ -90,7 +90,7 @@ public class RpRecord : DnsResourceRecord
         /// <param name="info">The information.</param>
         /// <param name="mailbox">The mailbox domain.</param>
         /// <param name="textName">The text domain.</param>
-        /// <exception cref="System.ArgumentNullException">
+        /// <exception cref="ArgumentNullException">
         /// If <paramref name="info"/> or <paramref name="mailbox"/> or <paramref name="textName"/> is null.
         /// </exception>
         public RpRecord(ResourceRecordInfo info, DnsString mailbox, DnsString textName)

src/DnsClient/Protocol/SoaRecord.cs

@@ -148,7 +148,7 @@ public class SoaRecord : DnsResourceRecord
         /// <param name="retry">The retry time.</param>
         /// <param name="expire">The expire time.</param>
         /// <param name="minimum">The minimum TTL.</param>
-        /// <exception cref="System.ArgumentNullException">
+        /// <exception cref="ArgumentNullException">
         /// If <paramref name="info"/> or <paramref name="mName"/> or <paramref name="rName"/> is null.
         /// </exception>
         public SoaRecord(ResourceRecordInfo info, DnsString mName, DnsString rName, uint serial, uint refresh, uint retry, uint expire, uint minimum)

src/DnsClient/Protocol/SrvRecord.cs

@@ -152,7 +152,7 @@ public class SrvRecord : DnsResourceRecord
         /// <param name="weight">The weight.</param>
         /// <param name="port">The port.</param>
         /// <param name="target">The target.</param>
-        /// <exception cref="System.ArgumentNullException">If <paramref name="info"/> or <paramref name="target"/> is null.</exception>
+        /// <exception cref="ArgumentNullException">If <paramref name="info"/> or <paramref name="target"/> is null.</exception>
         public SrvRecord(ResourceRecordInfo info, ushort priority, ushort weight, ushort port, DnsString target)
             : base(info)
         {

src/DnsClient/Protocol/TxtRecord.cs

@@ -58,7 +58,7 @@ public class TxtRecord : DnsResourceRecord
         /// <param name="info">The information.</param>
         /// <param name="values">The values.</param>
         /// <param name="utf8Values">The UTF8 values.</param>
-        /// <exception cref="System.ArgumentNullException">
+        /// <exception cref="ArgumentNullException">
         /// If <paramref name="info"/> or <paramref name="utf8Values"/> or <paramref name="values"/> is null.
         /// </exception>
         public TxtRecord(ResourceRecordInfo info, string[] values, string[] utf8Values)

src/DnsClient/Protocol/UriRecord.cs

@@ -67,7 +67,7 @@ public class UriRecord : DnsResourceRecord
         /// <param name="priority">The priority.</param>
         /// <param name="weight">The weight.</param>
         /// <param name="target">The target.</param>
-        /// <exception cref="System.ArgumentNullException">If <paramref name="info"/> or <paramref name="target"/> is null.</exception>
+        /// <exception cref="ArgumentNullException">If <paramref name="info"/> or <paramref name="target"/> is null.</exception>
         public UriRecord(ResourceRecordInfo info, int priority, int weight, string target)
             : base(info)
         {