Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DietPi-Update | Live patches via GitHub repository version file #4572

Merged
merged 7 commits into from
Jul 22, 2021
Merged

Conversation

MichaIng
Copy link
Owner

@MichaIng MichaIng commented Jul 21, 2021

Status: Ready

Commit list/description:

  • DietPi-Update | Add initial live patches to remote version file to test the implementation

+ DietPi-Update | Add initial live patches to remote version file to test the implementation
@MichaIng MichaIng added this to the v7.4 milestone Jul 21, 2021
+ DietPi-Update | Add support for live patches, when present on currently applied Git branch
+ DietPi-Update | Satisfy shellcheck
+ DietPi-Banner | Show new available DietPi live patches in banner, based on flag file
+ DietPi-PREP | Apply live patches via new mechanism and store info of already applied patches in .version file. Do this as early as possible, to have bugs fixed before using the scripts. Copy the separately stored image version file back in place, after .version got removed during a later cleanup step.
+ DietPi-Update | Adjust live patches a little to not create any file and explain the intention to beta users
+ DietPi-Update | A new live patching system has been implemented. This allows us to ship little fixes and updates, that are safe to apply with a one-line command, until the next DietPi version is released. Live patches are checked for together with DietPi updates and a notification is shown in the login banner as well, when new live patches have been found. When available, each patch can be individually applied or dismissed and the login banner won't bother you again about patches that you have seen in the dietpi-update menu already, regardless whether you applied them or not.
@MichaIng MichaIng merged commit e66ca7b into dev Jul 22, 2021
@MichaIng MichaIng deleted the patches branch July 22, 2021 22:29
@Joulinar
Copy link
Collaborator

Joulinar commented Jul 22, 2021

@MichaIng
I did a test on my VM. There seems to be something wrong with the red colour 😉

image

dietpi-launcher is marked in red as well


EDIT:
Ahh and the information on the header is not coloured at all. Is the intended?

image

@MichaIng MichaIng mentioned this pull request Jul 22, 2021
5 tasks
@MichaIng
Copy link
Owner Author

Both fixed already 🙂: e36a548

@Joulinar
Copy link
Collaborator

ok looks good on beta

@Joulinar
Copy link
Collaborator

Joulinar commented Aug 3, 2021

@MichaIng
Was thinking about this.

Should we give some more information on the available Live Patch on the initial screen

┌──────────────────────────────────────────────────┤ DietPi-Update ├───────────────────────────────────────────────────┐
│ No DietPi update is available, but live patches have been found for your current version to fix little bugs until    │
│ the next version is released.                                                                                        │
│                                                                                                                      │
│ Select a patch below for further details:                                                                            │
│                                                                                                                      │
│                                                   0 [not applied]                                                    │
│                                                                                                                      │
│                                                                                                                      │
│                                  <Ok>                                      <Exit>                                    │
│                                                                                                                      │
└──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘

Right now it's just giving a number 🤔

@MichaIng
Copy link
Owner Author

MichaIng commented Aug 4, 2021

Select a patch below for further details:

I hope this is clear that more info on a patch can be seen when selecting it? I wanted to keep it slim and have only a single description variable, which needs to be long enough for a brief explanation and a link to the related GitHub issue. But that one is too long for the whiptail menu 🤔. For that we'd need an additional variable, like a title.

@Joulinar
Copy link
Collaborator

Joulinar commented Aug 4, 2021

Just as an idea, what about naming the software title in question?

like 0 - Blynk [not applied]

So you already know what it is about and not just need to go to each patch. All just ideas. Probably we will not have that much live patched 😄

@MichaIng
Copy link
Owner Author

MichaIng commented Aug 4, 2021

It wouldn't be a big deal. We can add an additional array (https://github.com/MichaIng/DietPi/blob/master/.update/version) like G_LIVE_PATCH_NAME to store a short title for the menu and the details whiptail header and use it in DietPi v7.5 while it is simply ignored in DietPi v7.4. One thing I like about a sourced shell script with variables: You can simply extend or reorder and don't need to worry to break old client's ability to parse.

@Joulinar
Copy link
Collaborator

Joulinar commented Aug 4, 2021

personally I would vote on this but it's up to you 😜

JesusMtnez added a commit to JesusMtnez/homelab that referenced this pull request Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants