DietPi-Software | File Browser

[Joulinar]

DietPi-Software | filebrowser - new software title, ID 198

Status: ready

• add new software title filebrowser
• perform testing (RPi1, RPi3B+, RPi4B, VM)

Reference: #2560

Commit list/description:

• DietPi-Software | filebrowser - initial setup, add new software title, reserve ID 198
• DietPi-Software | filebrowser - add install and uninstall

[Joulinar]

@MichaIng

couple of questions I have:

• executable location /opt/filebrowser/
• config file location /mnt/dietpi_userdata/filebrowser/
• user home /mnt/dietpi_userdata/filebrowser/
• add user filebrowser to group dietpi
• service executed as user filebrowser
• service executed as group dietpi
• should we lock File Browser to a specific directory like /mnt/ or give full access
• default user to login root, dietpi or filebrowser
• port to be used 8085

At the moment I'm not happy how service is stopped. It looks more like a failure, than stopping a service.

Aug 24 22:29:04 DietPi3 systemd[1]: Stopping File Browser (DietPi)...
Aug 24 22:29:04 DietPi3 systemd[1]: filebrowser.service: Main process exited, code=exited, status=1/FAILURE
Aug 24 22:29:04 DietPi3 systemd[1]: filebrowser.service: Failed with result 'exit-code'.
Aug 24 22:29:04 DietPi3 systemd[1]: Stopped File Browser (DietPi).

[MichaIng]

As we discussed, agreed with all your suggestions above. Not sure about the default login user name, as we have no consistent one for other web interfaces either, sometimes root, sometimes admin, sometimes dietpi...

Probably using dietpi fits best, also to align other software with, so that it is not the number 1-5 attempt of a brute-force attack, but still a shared username for every software/web interface?

[Joulinar]

ok let's go with user dietpi. We could add on or docs how to add new users if needed.

[Joulinar]

ok from my side testing is done, I checked installation on all my platforms (RPi1, RPi3B+, RPi4B, VM). Ready for review from my end.

[MichaIng]

So if I understand it right, v1.x used a config file while v2.x uses a database only: https://filebrowser.org/upgrade-from-1.x
And the -c option is then used to migrate an old config or import one (as a convenience feature so it can be pre-configured via text editor): https://filebrowser.org/cli/filebrowser-config-import

Since we can use the CLI to create and configure the database directly, no need for this. What we may add in the future, is to allow users placing a custom config file and importing it automatically at install.

[Joulinar]

ok will have a look tomorrow during the day on the changes you requested.

[Joulinar]

Ok I did the adjustments and removed the temp code. One thing I'm not sure with are the file and/or directory permissions if created by filebrowser. Everything will be created with 775 permissions.

[MichaIng]

Hah, it DOES have a sharing feature, right below the rename button. Makes the file(s) available via password-protected link for a defined time range. How could I have overseen that earlier 😄.

But the most important question these days: Where is the dark mode? 🤣
Database is only accessible when the service has been stopped, else it shows "timeout" 🤔. But then:

/mnt/dietpi_userdata/filebrowser# /opt/filebrowser/filebrowser config cat
Sign up:          false
Create User Dir:  false
Auth method:      json
Shell:

Branding:
  Name:
  Files override:
  Disable external links:  false

Server:
  Log:           stdout
  Port:          8085
  Base URL:
  Root:          /mnt
  Socket:
  Address:       0.0.0.0
  TLS Cert:
  TLS Key:
  Exec Enabled:  false

Defaults:
  Scope:         .
  Locale:        en
  View mode:     list
  Single Click:  false
  Commands:
  Sorting:
    By:   name
    Asc:  false
  Permissions:
    Admin:     false
    Execute:   true
    Create:    true
    Rename:    true
    Modify:    true
    Delete:    true
    Share:     true
    Download:  true

Auther configuration (raw):

{
  "recaptcha": null
}

No dark mode, but good to see what's possible.

I'm impressed, I have to say. Many important features are there, even a command line, showing file hashes and such, but all well placed, looks clean and sorted.

[MichaIng]

Ready from my end 👍.

[Joulinar]

Feel free to move into dev. Will have a look later the evening and create docs tomorrow.

[Joulinar]

No dark mode, but good to see what's possible.

BTW it is supporting dark mode. Available setting on admin panel