Feature: ConstantInt - support get from string #75 #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Patsura <talk@dmtry.me>
ovr
force-pushed
the
constant-int-from-string
branch
from
20ecfbd
to
8019512
Compare
Signed-off-by: Dmitry Patsura <talk@dmtry.me>
ovr
force-pushed
the
constant-int-from-string
branch
from
c169e94
to
795dfdb
Compare
MichaReiser
reviewed
Dec 14, 2018
Signed-off-by: Dmitry Patsura <talk@dmtry.me>
ovr
force-pushed
the
constant-int-from-string
branch
from
0ee8f25
to
37ae6ec
Compare
MichaReiser
reviewed
Dec 21, 2018
| @@ -199,6 +199,8 @@ declare namespace llvm { | |||
| private constructor(); | |||
|
|
|||
| readonly value: number; | |||
There was a problem hiding this comment.
Should we add a check to get that throws if the value is larger than what JS supports?
Thanks @MichaReiser for idea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dmitry Patsura talk@dmtry.me