Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add libsignal-service implementation with Hyper, Tungstenite and Tokio #74

Merged
merged 4 commits into from
Mar 8, 2021
Merged

Add libsignal-service implementation with Hyper, Tungstenite and Tokio #74

merged 4 commits into from
Mar 8, 2021

Conversation

gferon
Copy link
Collaborator

@gferon gferon commented Mar 8, 2021

No description provided.

@gferon gferon requested a review from rubdos March 8, 2021 09:25
rubdos
rubdos reviewed Mar 8, 2021
View reviewed changes
Copy link
Member

@rubdos rubdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not gonna read the whole Hyper thingy, it looks alright ;p

Other than that, we probably want the hyper/actix features in a separate MR?

libsignal-service/Cargo.toml Outdated Show resolved Hide resolved
@gferon
Copy link
Collaborator Author

gferon commented Mar 8, 2021

@rubdos if it's fine with you, I'll squash and merge this one.

@gferon gferon merged commit 3e5d495 into whisperfish:master Mar 8, 2021
@gferon gferon deleted the hyper-impl branch March 8, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubdos rubdos rubdos left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gferon @rubdos