feat: migrate cli scripts and their test cases #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## eslint-8 #14 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 9 9
Lines 192 195 +3
==========================================
+ Hits 192 195 +3
Continue to review full report at Codecov.
|
|
Parent: sarbbottam#337, #13 |
Merged
PaperStrike
commented
Nov 7, 2021
|
This needs to be rebased, which will hopefully resolve the test failures. |
3 tasks
* add explicit `process.exit` call to `diff.js` * turn tests' `exitStatus` into a promise that resolves to the value passed to `process.exit`
PaperStrike
force-pushed
the
bin-async
branch
from
7806870
to
814d16f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #13 (comment)
This adapts the bin scripts and their test files to the asynchronous API in #13.