Import URL explicitly to work in node 8 #80
Conversation
There was a problem hiding this comment.
@ilyamkin Seems like tests are failing now.
Could you take a look at them please?
|
@ilyamkin Could you also add Node 8 to |
|
All tests are passing now (including node 8). There is one new line that I've added, so coverage is not 100% anymore. Wondering how I can test it. |
|
Hmmm lets just always suppress the error, like we did before. |
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 14 14
Lines 160 160
Branches 14 14
=====================================
Hits 160 160
Continue to review full report at Codecov.
|
|
@all-contributors Please add @ilyamkin for code |
|
I've put up a pull request to add @ilyamkin! 🎉 |
|
🎉 This PR is included in version 1.11.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
* fix: import URL explicitly to work in node 8 * fix: rely on error code, add node 8 to travis * fix: always suppress the error
What:
Import URL module explicitly. Fixes #61
Why:
In order to make the plugin work in Node 8.
How:
Apart from necessary import, I've added a condition in catch to suppress only TypeErrors (invalid links). It would make it easier to debug for those who are using old Node versions.
Checklist: