Support SDK Version >=7, and assorted cleanups #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 27, 2013 12:30
Necessary for versions of Android Studio >= 0.4.0.
…attributes. They are determined from the values in build.gradle.
|
@nikclayton Thanks, this looks great! Do you mind if I put in a reference to your app in the docs for applications that showcase this library? I'll also publish a 0.2 version to Maven shortly will reflect these changes. |
MichaelEvans
added a commit
that referenced
this pull request
Dec 30, 2013
Support SDK Version >=7, and assorted cleanups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Michael,
I'm particularly interested in seeing the minSdKVersion change go in, since I have an app (https://github.com/nikclayton/android-squeezer) that supports SDK 7 and up and I'd like to use the ColorArt library with it. As far as I can tell there's nothing in ColorArt that uses any higher SDK features, so this should be safe.
The other changes are just straightforward cleanups.
Thanks, Nik