This repository has been archived by the owner on May 2, 2020. It is now read-only.
Optional markdown style configuration
#41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optional `markdown` style configuration. Stripped trailing spaces. Added: `using Lexicon` to Example to make it selfcontained.
| for (k, v) in mdstyle | ||
| !(k in reg_keys) && error("Invalid mdstyle key: `$k`. Valid keys: [$(join(reg_keys, ", "))].") | ||
| !(v in vaild_tags) && error("Invalid mdstyle value: `$v`. Valid values: [$(join(vaild_tags, ", "))].") | ||
| end |
There was a problem hiding this comment.
The ! ... && style conditions may read better as ... || conditions. So:
length(keys(mdstyle)) == length(reg_keys) || error(...
(k in reg_keys) || error(...
(v in vaild_tags) || error(...
They should be logically equivalent I think.
There was a problem hiding this comment.
Will change that.
I just started with julia and decided for the beginning to use only &&
Both && and || associate to the right, but && has higher precedence than || does (http://julia.readthedocs.org/en/latest/manual/control-flow/#short-circuit-evaluation)
|
Great stuff! Left a couple of comments inline for discussion. |
|
Thanks for the feedback: anyway my last push I have to test as I recomple julia. I will do that a bit later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#39
markdownstyle configuration.using Lexiconto Example to make it selfcontained.mkdocsseems to have not this issueI did not add any additional tests.