Moved Defaults to Non Abstract Provider

For certain scenarios, the default static property isn’t necessary. It’s a good base class to have, but not necessary for the abstract, which most might choose to extend from.
MichaelJ2324 · Jun 16, 2017 · 844c194 · 844c194
1 parent 4c84a91
commit 844c194
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 20 deletions.
diff --git a/src/Endpoint/Provider/AbstractEndpointProvider.php b/src/Endpoint/Provider/AbstractEndpointProvider.php
@@ -8,27 +8,11 @@
 
 abstract class AbstractEndpointProvider implements EndpointProviderInterface
 {
-
-    /**
-     * List of default endpoints to load
-     * @var array
-     */
-    protected static $_DEFAULT_ENDPOINTS = array();
-
     /**
      * @var array
      */
     protected $registry = array();
 
-    public function __construct() {
-        foreach(static::$_DEFAULT_ENDPOINTS as $name => $epData){
-            if (!isset($epData['properties'])){
-                $epData['properties'] = array();
-            }
-            $this->registerEndpoint($name,$epData['class'],$epData['properties']);
-        }
-    }
-
     /**
      * @inheritdoc
      * @throws InvalidRegistration

diff --git a/src/Endpoint/Provider/DefaultEndpointProvider.php b/src/Endpoint/Provider/DefaultEndpointProvider.php
@@ -0,0 +1,22 @@
+<?php
+
+namespace MRussell\REST\Endpoint\Provider;
+
+
+class DefaultEndpointProvider extends AbstractEndpointProvider
+{
+    /**
+     * List of default endpoints to load
+     * @var array
+     */
+    protected static $_DEFAULT_ENDPOINTS = array();
+
+    public function __construct() {
+        foreach(static::$_DEFAULT_ENDPOINTS as $name => $epData){
+            if (!isset($epData['properties'])){
+                $epData['properties'] = array();
+            }
+            $this->registerEndpoint($name,$epData['class'],$epData['properties']);
+        }
+    }
+}
diff --git a/tests/Endpoint/AbstractEndpointProviderTest.php b/tests/Endpoint/AbstractEndpointProviderTest.php
@@ -3,6 +3,7 @@
 namespace MRussell\REST\Tests\Endpoint;
 
 use MRussell\Http\Request\JSON;
+use MRussell\REST\Endpoint\Provider\DefaultEndpointProvider;
 use MRussell\REST\Endpoint\Provider\EndpointProviderInterface;
 use MRussell\REST\Tests\Stubs\Endpoint\AuthEndpoint;
 use MRussell\REST\Tests\Stubs\Endpoint\EndpointProvider;
@@ -39,7 +40,7 @@ public function tearDown()
     }
 
     /**
-     * @covers ::__construct
+     * @covers MRussell\REST\Endpoint\Provider\DefaultEndpointProvider::__construct
      * @covers ::registerEndpoint
      */
     public function testConstructor(){

diff --git a/tests/Stubs/Endpoint/EndpointProvider.php b/tests/Stubs/Endpoint/EndpointProvider.php
@@ -6,5 +6,4 @@
 
 class EndpointProvider extends AbstractEndpointProvider
 {
-
 }
diff --git a/tests/Stubs/Endpoint/EndpointProviderWithDefaults.php b/tests/Stubs/Endpoint/EndpointProviderWithDefaults.php
@@ -4,9 +4,9 @@
 
 
 use MRussell\Http\Request\JSON;
-use MRussell\REST\Endpoint\Provider\AbstractEndpointProvider;
+use MRussell\REST\Endpoint\Provider\DefaultEndpointProvider;
 
-class EndpointProviderWithDefaults extends AbstractEndpointProvider
+class EndpointProviderWithDefaults extends DefaultEndpointProvider
 {
     protected static $_DEFAULT_ENDPOINTS = array(
         'auth' => array(