Merge pull request #28 from MichaelJ2324/2.0

Updated Rest-Client Library + Unit Tests
MichaelJ2324 · Aug 15, 2017 · 789e48f · 789e48f
2 parents 4645290 + 676a420
commit 789e48f
Show file tree

Hide file tree

Showing 5 changed files with 109 additions and 16 deletions.
diff --git a/composer.json b/composer.json
@@ -20,7 +20,7 @@
   ],
   "require": {
     "php": ">=5.3.0",
-    "michaelj2324/php-rest-client": "~1.0"
+    "michaelj2324/php-rest-client": ">=1.3.0"
   },
   "require-dev": {
     "phpunit/phpunit": "~4.0|~5.0"

diff --git a/src/Auth/SugarOAuthController.php b/src/Auth/SugarOAuthController.php
@@ -9,9 +9,7 @@
 
 class SugarOAuthController extends AbstractOAuth2Controller
 {
-    protected static $_OAUTH_HEADER = 'OAuth-Token';
-
-    protected static $_TOKEN_VALUE = '%s';
+    protected static $_AUTH_HEADER = 'OAuth-Token';
 
     protected static $_DEFAULT_GRANT_TYPE = self::OAUTH_RESOURCE_OWNER_GRANT;
 
@@ -26,6 +24,14 @@ class SugarOAuthController extends AbstractOAuth2Controller
         'platform' => 'api'
     );
 
+    /**
+     * @inheritdoc
+     */
+    protected function getAuthHeaderValue()
+    {
+        return $this->token['access_token'];
+    }
+
     /**
      * @inheritdoc
      * Load Stored Token based on Credentials

diff --git a/src/Endpoint/Abstracts/AbstractSugarBeanEndpoint.php b/src/Endpoint/Abstracts/AbstractSugarBeanEndpoint.php
@@ -160,31 +160,52 @@ public function getModule(){
     }
 
     /**
-     * Auto configure uploads
-     * @param RequestInterface $Request
-     * @return RequestInterface
+     * Configure Uploads on Request
+     * @inheritdoc
+     * @codeCoverageIgnore
      */
     protected function configureRequest(RequestInterface $Request)
     {
         $Request = parent::configureRequest($Request);
+        return $this->configureUploads($Request);
+    }
+
+    /**
+     * Configure the Uploads Data on the Request Object
+     * @param RequestInterface $Request
+     * @return RequestInterface
+     */
+    protected function configureUploads(RequestInterface $Request)
+    {
         $Request->setUpload($this->upload);
-        if ($Request->getUpload()){
+        if (!empty($this->_files)){
             foreach($this->_files as $key => $properties){
                 $Request->addFile($key,$properties['path'],$properties['mimeType'],$properties['filename']);
             }
         }
         return $Request;
     }
 
+    /**
+     * Add a reset for Upload Settings
+     * @inheritdoc
+     * @codeCoverageIgnore
+     */
     protected function configureResponse(ResponseInterface $Response)
     {
+        $this->resetUploads();
+        return parent::configureResponse($Response);
+    }
+
+    /**
+     * Reset the Upload Settings back to defaults
+     */
+    protected function resetUploads(){
         if ($this->upload){
-            //Reset file uploads after uploading
-            $this->upload = FALSE;
-            $this->_files = array();
             $this->getData()->reset();
         }
-        return parent::configureResponse($Response);
+        $this->upload = FALSE;
+        $this->_files = array();
     }
 
     /**
@@ -368,11 +389,11 @@ public function attachFile($fileField,$filePath,$deleteOnFail = false,$mimeType
     {
         $this->setCurrentAction(self::BEAN_ACTION_ATTACH_FILE,array($fileField));
         $this->configureFileUploadData($deleteOnFail);
-        $this->_files[$fileField] = array(
+        $this->addFile($fileField,array(
             'path' => $filePath,
             'mimeType' => $mimeType,
             'filename' => $uploadName
-        );
+        ));
         return $this->execute();
     }
 
@@ -395,11 +416,11 @@ public function tempFile($fileField,$filePath,$deleteOnFail = false,$mimeType =
         $this->set($idKey,'temp');
         $this->setCurrentAction(self::BEAN_ACTION_TEMP_FILE_UPLOAD,array($fileField));
         $this->configureFileUploadData($deleteOnFail);
-        $this->_files[$fileField] = array(
+        $this->addFile($fileField,array(
             'path' => $filePath,
             'mimeType' => $mimeType,
             'filename' => $uploadName
-        );
+        ));
         return $this->execute();
     }
 
@@ -419,4 +440,19 @@ protected function configureFileUploadData($deleteOnFail = FALSE){
         $this->setData($data);
     }
 
+    /**
+     * Add a file to the internal Files array to be added to the Request
+     * @param $name
+     * @param array $properties
+     * @return $this
+     */
+    protected function addFile($name,array $properties)
+    {
+        if (isset($properties['path'])){
+            $this->upload = TRUE;
+            $this->_files[$name] = $properties;
+        }
+        return $this;
+    }
+
 }
diff --git a/tests/Auth/SugarOAuthControllerTest.php b/tests/Auth/SugarOAuthControllerTest.php
@@ -2,8 +2,10 @@
 
 namespace Sugarcrm\REST\Tests\Auth;
 
+use MRussell\Http\Request\JSON;
 use Sugarcrm\REST\Auth\SugarOAuthController;
 use Sugarcrm\REST\Storage\SugarStaticStorage;
+use Sugarcrm\REST\Tests\Stubs\Auth\SugarOAuthStub;
 
 
 /**
@@ -111,4 +113,16 @@ public function testUpdateCredentials(){
             'platform' => array()
         ),$Auth->getCredentials());
     }
+
+    /**
+     * @covers ::getAuthHeaderValue
+     */
+    public function testAuthHeader()
+    {
+        $Auth = new SugarOAuthStub();
+        $Request = new JSON();
+        $this->assertEquals($Auth,$Auth->configureRequest($Request));
+        $headers = $Request->getHeaders();
+        $this->assertEquals('bar',$headers['OAuth-Token']);
+    }
 }
diff --git a/tests/Endpoint/AbstractSugarBeanEndpointTest.php b/tests/Endpoint/AbstractSugarBeanEndpointTest.php
@@ -379,5 +379,42 @@ public function testConfigureFileUploadData(){
             'oauth_token' => 'bar'
         ),$Bean->getData()->asArray());
     }
+
+    /**
+     * @covers ::attachFile
+     * @covers ::tempFile
+     * @covers ::addFile
+     * @covers ::resetUploads
+     * @covers ::configureUploads
+     */
+    public function testFileAttachments()
+    {
+        $Bean = new Module();
+        $Bean->setBaseUrl('http://localhost/rest/v10/');
+        $Bean->set('id','12345a');
+        $Bean->setModule('Accounts');
+        $Reflection = new \ReflectionClass('Sugarcrm\REST\Endpoint\Abstracts\AbstractSugarBeanEndpoint');
+        $upload = $Reflection->getProperty('upload');
+        $upload->setAccessible(TRUE);
+        $_files = $Reflection->getProperty('_files');
+        $_files->setAccessible(TRUE);
+        $Auth = new SugarOAuthStub();
+        $Bean->setAuth($Auth);
+        $this->assertEquals($Bean,$Bean->attachFile('uploadfile',__FILE__));
+        $this->assertEquals(Module::BEAN_ACTION_ATTACH_FILE,$Bean->getCurrentAction());
+        $this->assertEquals(array(),$_files->getValue($Bean));
+        $this->assertEquals(FALSE,$upload->getValue($Bean));
+        $this->assertEmpty($Bean->getData()->asArray());
+        $rBody = $Bean->getRequest()->getBody();
+        $this->assertNotEmpty($rBody['uploadfile']);
+        $this->assertEquals($Bean,$Bean->tempFile('uploadfile',__FILE__));
+        $this->assertEquals(Module::BEAN_ACTION_TEMP_FILE_UPLOAD,$Bean->getCurrentAction());
+        $this->assertEquals(array(),$_files->getValue($Bean));
+        $this->assertEquals(FALSE,$upload->getValue($Bean));
+        $this->assertEmpty($Bean->getData()->asArray());
+        $this->assertEquals('temp',$Bean['id']);
+        $rBody = $Bean->getRequest()->getBody();
+        $this->assertNotEmpty($rBody['uploadfile']);
+    }
 }