Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebUI] Read-only mode for serving publicly #402

Closed
tazjin opened this issue Jun 15, 2020 · 1 comment · Fixed by #407
Closed

[WebUI] Read-only mode for serving publicly #402

tazjin opened this issue Jun 15, 2020 · 1 comment · Fixed by #407
Labels
enhancement New feature or request WebUI Concerns the Web UI

Comments

@tazjin
Copy link

tazjin commented Jun 15, 2020

Hey, and thanks for git-bug, it is an amazing idea!

We've started using git bug for our community monorepo at code.tvl.fyi and would like to be able to host a read-only web UI so that we can link to bugs etc., without people needing to pull them locally.

It seems that the web UI currently expects to be launched with an identity, and that it always provides features such as a comment field. Have you considered adding a read-only mode which could be used for serving it publicly? Alternatively, would patches for supporting this be welcome?

Thanks!

@MichaelMure MichaelMure added the WebUI Concerns the Web UI label Jun 15, 2020
@MichaelMure MichaelMure changed the title Read-only web UI for serving publicly [WebUI] Read-only mode for serving publicly Jun 15, 2020
@MichaelMure
Copy link
Owner

Yes this would make sense.

At the moment, the WebUI implicitly use the default User of the git repo it's launched from as the active user in the WebUI. The plan is to have it eventually accept external authentication (OAuth typically) so that people without git commit access can participate on the bugtracker.

But having this implies that there is sometimes no logged user and the WebUI should be read-only at that point. Ideally this read-only feature is framed that way: not as a special hardcoded mode, but as a fallback when there is no logged user. It would then be just a matter of adding a new --read-only flag to the webui command to run the GraphQL API without a user.

This has some implication in the GraphQL API though: even if Repository.userIdentity in the GraphQL API can be null, there is still the assumption in some places (typically the mutations) that a user always exist.

I very much welcome patches to do that.

@MichaelMure MichaelMure added the enhancement New feature or request label Jun 15, 2020
lukegb added a commit to lukegb/git-bug that referenced this issue Jun 18, 2020
lukegb added a commit to lukegb/git-bug that referenced this issue Jun 18, 2020
lukegb added a commit to lukegb/git-bug that referenced this issue Jun 18, 2020
lukegb added a commit to lukegb/git-bug that referenced this issue Jun 18, 2020
MichaelMure pushed a commit to lukegb/git-bug that referenced this issue Jun 26, 2020
MichaelMure pushed a commit to lukegb/git-bug that referenced this issue Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request WebUI Concerns the Web UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants