[ls] add support for different output formats #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an optional flag to the ls command that allows users to specify the format they wish to dump the output as. Currently, supported parameters are 'default', 'plain' and 'json'.
MichaelMure
requested changes
Jun 16, 2020
commands/ls.go
Outdated
| } | ||
|
|
||
| jsonObject, _ := json.MarshalIndent(jsonBug, "", " ") | ||
| fmt.Printf("%s\n", jsonObject) |
There was a problem hiding this comment.
printing bugs one by one means the output is not a well formed JSON document. It should be an array.
There was a problem hiding this comment.
This should be resolved now, oops.
This prints all the bugs in a JSON array instead of one by one.
MichaelMure
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for different output formats for the ls command using the
-for-formatflag. Current accepted formats are:default: outputs the normal ls result. If an invalid specifier for the flag is received or the flag is not specified,defaultwill be used.plain/plaintext: outputs only the status of the bug and the title.json: outputs each bug as a JSON object.Works towards #392 and gets the groundwork in for other flags/output formats in the future. Markdown and org-mode to come!