Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request #8

Closed
KelvinPac opened this issue Jun 9, 2018 · 10 comments
Closed

Feature request #8

KelvinPac opened this issue Jun 9, 2018 · 10 comments
Labels
enhancement New feature or request
Milestone

Comments

@KelvinPac
Copy link

Cheers for this awesome library, I have already tried it and it was awesome. I am storing the geofirestore locations on the same collection so doing a query will return me the document snapshots. Is there a way to limit the results just like in Firestore? And is there a way I would pass another Firestore query to geofirestore so that it would also order the results or sort them in a certain way using the other database fields just as we can do in Firestore.
Thanks.

@KelvinPac
Copy link
Author

With the current setup I found the library using, if am storing the geofirestore locations on the same collection as my documents, doing a query will return all documents which match, but on large collections the results may be huge. Will we be seeing some kind of pagination or something similar soon? . Am already using this awesome lib in production

@MichaelSolati MichaelSolati added the enhancement New feature or request label Jun 10, 2018
@MichaelSolati
Copy link
Owner

It's in my plans for version 2.0.0 or 2.1.0 However there will be a lot of changes come 2.x.x, so keep that in mind.

@MichaelSolati MichaelSolati added this to the v2.1.0 milestone Jun 14, 2018
@ZenPylon
Copy link
Contributor

I also am interested in additional querying capability. I have a tight timeline for an app I'm trying to develop, so I might create a fork and give it a shot. Would love to hear if you already have any ideas on implementation, but I'll probably try to allow access to the generated query somehow. I think query criteria are chainable in Firestore?

Anyway, thanks so much for developing this library! Looks like you've put quite a bit of work in!

@MvRemmerden
Copy link

Any of you already started working on this? If not, I might take a shot at it, being able to limit the query in order to not exhaust my spark limits within a couple of hours will be critical for me.

@ZenPylon
Copy link
Contributor

@MvRemmerden Haven't had a chance yet -- go for it!

@MichaelSolati
Copy link
Owner

Oh... What's this?

@MvRemmerden
Copy link

That looks amazing, will be the first thing I'm going to test tomorrow morning. Thanks! 😃

@MvRemmerden
Copy link

I'm actually struggling a bit to get this implemented, would it be possible to post a quick example of how to do this?

@MichaelSolati
Copy link
Owner

@MvRemmerden I've had to make a few changes, but if you wanted to test it now you can npm i MichaelSolati/geofirestore/v2.1.0. Note that for your query functions you'll need to refer to the field in your object starting with d. and index your database on that field.

You may wanna peak at this query and this index

@MichaelSolati
Copy link
Owner

Custom queries should now be working! Try npm i geofirestore@2.1.0

It'll be worth reading the docs here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants