Stop a single exception from killing a whole cron thread #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
This seems like an OK solution for now. The part I like about this is if you have long running tasks, there's no way that fact can interfere with how often they run. The downside here is there is no hope of the user handling exceptions from these actions. Would you mind adding documentation to this effect? Beyond that, I'm happy to merge this. Thanks! |
|
No problem. I'll add some documentation to the function. |
|
Done. |
MichaelXavier
added a commit
that referenced
this pull request
Jul 3, 2015
Stop a single exception from killing a whole cron thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, if a cron job does something that causes it to throw an exception in IO (like making an API call to a web server that happens to be down), the whole thread gets killed. This means that the job quits running until the application is restarted. This PR prevents that behavior from occurring.