Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add icons field in manifest.json #64

Merged
merged 3 commits into from
Dec 12, 2023
Merged

chore: add icons field in manifest.json #64

merged 3 commits into from
Dec 12, 2023

Conversation

zouhangwithsweet
Copy link
Contributor

before:

after:

lawvs
lawvs approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@lawvs lawvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@MichaelYuhe MichaelYuhe merged commit 1302be7 into MichaelYuhe:main Dec 12, 2023
1 check passed
@zouhangwithsweet
Copy link
Contributor Author

Merge so quickly. :)
Please check the build.yml, it's will update build file to artifact for CI/CD @MichaelYuhe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawvs lawvs lawvs approved these changes

@MichaelYuhe MichaelYuhe MichaelYuhe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zouhangwithsweet @lawvs @MichaelYuhe