Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chrome.tabs.group maybe error #84

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Conversation

hqwuzhaoyi
Copy link
Contributor

When there is a large amount of tags, the following situations may occur

Unchecked runtime.lastError: Tabs can only be moved to and from normal windows.

When there is a large amount of tags, the following situations may occur

Unchecked runtime.lastError: Tabs can only be moved to and from normal windows.
@hqwuzhaoyi
Copy link
Contributor Author

CleanShot 2023-12-15 at 14 06 35@2x

I found that chrome.tabs.group sometimes requires the windowId parameter.

Copy link
Owner

@MichaelYuhe MichaelYuhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@MichaelYuhe MichaelYuhe merged commit d9d87a5 into MichaelYuhe:main Dec 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants