-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not add interpolated points between points with null values. #35
base: master
Are you sure you want to change the base?
Do not add interpolated points between points with null values. #35
Conversation
Hey, first of all thanks for the contribution! I did not merge it so far because I'm unsure about the "fence posts", the PR surpresses interpolation between two points in case one of the points includes a null value however the null point itself will be part of the result added either in line 204-206 or 220-222. Probably this still works since other flot plugins will ignore the null point but it might produce artifacts e.g. in case the last point is null. I assume the visibile line would just end before the plot borders ... If you have time it would be great if you could adjust the PR and maybe add an example for the test folder? Else I will tackle that myself but it might take some time... Best Michael |
Works fine. My test case was: |
after this effect, my graph working fine |
wow that has a been a long time open... after checking documentation "If a null is specified as a point or if one of the coordinates is null or couldn't be converted to a number, the point is ignored when drawing. As a special case, a null value for lines is interpreted as a line segment end, i.e. the points before and after the null value are not connected." thus the desired behavior would probably be to have line segments in case someone wants them joint it would be his choice to filter null values PR
maybe some preprocessing
|
did add a few commits to a copy of the branch with this implementation |
shall I give pull request after address this issue with testcases |
Hopefully fixes #34