Skip to content

Commit

Permalink
Merge pull request #38 from Michaelpalacce/develop
Browse files Browse the repository at this point in the history
[develop] v28.2.0
  • Loading branch information
Michaelpalacce committed Aug 7, 2020
2 parents aee68c7 + af5625b commit 30b33e2
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 10 deletions.
3 changes: 3 additions & 0 deletions UPDATELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
28.2.0
- Routers can now be added more than once using the router.add( 'path', router ) syntax

28.1.1
- Updated documentation a bit
- EventRequest.sendError is now async
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"test": "nyc --reporter=lcov --reporter=text-summary node test.js --debug",
"deploy": "npm run test && npm publish"
},
"version": "28.1.1",
"version": "28.2.0",
"devDependencies": {
"nyc": "^15.1.0"
}
Expand Down
36 changes: 27 additions & 9 deletions server/components/routing/router.js
Original file line number Diff line number Diff line change
Expand Up @@ -301,29 +301,47 @@ class Router extends PluginInterface
*/
_concat( router, path = null )
{
let middlewares;

if ( path !== null )
{
for ( const middleware of router.middleware )
middlewares = [];
for ( const originalMiddleware of router.middleware )
{
if ( middleware.route === '/' )
middleware.route = '';
let route = originalMiddleware.route;

if ( route === '/' )
route = '';

if ( middleware.route instanceof RegExp )
if ( originalMiddleware.route instanceof RegExp )
{
let regex = middleware.route.source;
let regex = originalMiddleware.route.source;

if ( regex.startsWith( '^' ) )
regex = regex.substring( 1 );

middleware.route = new RegExp( `${path}${regex}`, middleware.route.flags );
continue;
route = new RegExp( `${path}${regex}`, originalMiddleware.route.flags );
}
else
{
route = path + route;
}

middleware.route = path + middleware.route;
middlewares.push( new Route({
handler : originalMiddleware.getHandler(),
method : originalMiddleware.getMethod(),
middlewares : originalMiddleware.getMiddlewares(),
route
})
);
}
}
else
{
middlewares = router.middleware;
}

this.middleware = this.middleware.concat( router.middleware );
this.middleware = this.middleware.concat( middlewares );

for ( const [key, value] of Object.entries( router.globalMiddlewares ) )
this.define( key, value );
Expand Down

0 comments on commit 30b33e2

Please sign in to comment.