Relax clap version requirements #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft status since I'm still fixing some depreciation warnings. |
|
Hi! Unfortunately, there's a problem with newer versions of
...on the other hand, while taking this picture I have noticed that giving the field a custom name works fine, so that's very interesting and might be a good enough workaround. |
|
Interesting, do you know if this is a bug or a feature in |
Add unicode support to the updated clap dependency
|
Thanks for the PR! There are still some depreciation warnings I'd like to fix. Particularly with errors, I would like to parse the clap's error message to display it nicely in the GUI. |
|
I can't reproduce the depreciation warnings anymore. I think they were fixed in 26f6983 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #35 :) I suppose this simplifies using klask greatly, but I'm not sure there are other implications.