Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpage in master 2 #79

Merged

Conversation

stereobooster
Copy link
Collaborator

@stereobooster stereobooster commented Jan 3, 2018

Readme generated from data.json

@stereobooster stereobooster mentioned this pull request Jan 3, 2018
@stereobooster stereobooster mentioned this pull request Jan 4, 2018
3 tasks
@stereobooster stereobooster force-pushed the webpage-in-master-2 branch 2 times, most recently from 7431c92 to 3b3c855 Compare January 14, 2018 09:00
@stereobooster
Copy link
Collaborator Author

stereobooster commented Jan 14, 2018

@MicheleBertoli I rebased this branch. Now data.json is the source of truth and you can generate Readme based on it. WDYT?

@MicheleBertoli
Copy link
Owner

Thank you very much, @stereobooster.
I like the idea of the data.json, and I'm happy to merge this.
It'd be great if we could centre the tick inside the cell - do you think it's feasible?
Also, nit: I don't really like the if/else-if on the headers - do you mind using an object?

@stereobooster
Copy link
Collaborator Author

Easy. WIll fix tomorrow

@stereobooster
Copy link
Collaborator Author

Here is how centered ticks looks like. If you ask me this is strange

screen shot 2018-01-23 at 11 03 46

@stereobooster
Copy link
Collaborator Author

We can use pad option to make markdown table more compact.

@MicheleBertoli
Copy link
Owner

Thanks for improving it but I agree it doesn't look right.
Ideally, it should look like the current README (alternate row colours, column border, etc.).
Do you think it's possible with markdown-table?

@stereobooster
Copy link
Collaborator Author

Not sure I understand what you want.

Current version (1):

| [aphrodite](https://github.com/Khan/aphrodite) | 1.2.3        ||||||

I can do this instead (2):

| [aphrodite](https://github.com/Khan/aphrodite) | 1.2.3 ||||||

@stereobooster
Copy link
Collaborator Author

Ideally, it should look like the current README (alternate row colours, column border, etc.).

If you are talking about tweaking styles for table in html version. I agree, but this is out of scope of current PR. This PR about generating README from data.json

@MicheleBertoli
Copy link
Owner

I was always talking about the README, especially when I said:

It'd be great if we could centre the tick inside the cell - do you think it's feasible?

It seems there's a been a misunderstanding and you centered the ticks on the website (which, I agree, is out of the scope of this PR) instead of doing it in the README.
I also thought your screenshot showed the README (therefore my comment).

So, it'd be great if we could centre the tick inside the cell of the README - and leave the website as it is now.
Does that make sense?
Thank you very much!

@stereobooster
Copy link
Collaborator Author

Done. Check a diff of the README

@stereobooster
Copy link
Collaborator Author

@MicheleBertoli
Copy link
Owner

Yay, thank you very much!

@MicheleBertoli MicheleBertoli merged commit 9ac18b1 into MicheleBertoli:master Jan 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants