Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put it into the git ignore #79

Open
filip326 opened this issue Jan 12, 2024 · 13 comments
Open

Put it into the git ignore #79

filip326 opened this issue Jan 12, 2024 · 13 comments
Assignees
Labels
dependencies Pull requests that update a dependency file invalid This doesn't seem right

Comments

@filip326
Copy link
Collaborator

          simply because it's not in the gitignore

Originally posted by @Barsch2006 in #78 (comment)

@filip326 filip326 self-assigned this Jan 12, 2024
@filip326 filip326 linked a pull request Jan 12, 2024 that will close this issue
@chfuchte
Copy link
Collaborator

we should check, if its not easier with the package-lock 'cause npm ciin the action

@chfuchte
Copy link
Collaborator

@chfuchte
Copy link
Collaborator

I talked shit. It has a proper reason to exist on github

@chfuchte chfuchte added dependencies Pull requests that update a dependency file invalid This doesn't seem right labels Jan 12, 2024
@filip326
Copy link
Collaborator Author

We should check if its possible to use the yarn.lock inside the github actions

@filip326
Copy link
Collaborator Author

@oglimmer you've got most experince with gh actions and this stuff

@chfuchte
Copy link
Collaborator

its completly possible. its just a question, if its required after a year of development..

@chfuchte
Copy link
Collaborator

and since the actions've used npm since they exist, I don't get why you used yarn the whole time ;)

@filip326
Copy link
Collaborator Author

and since the actions've used npm since they exist, I don't get why you used yarn the whole time ;)

Because @Mickhat asked me to

@chfuchte
Copy link
Collaborator

aha (oder auf Deutsch: immer schön die Schuld auf andere schieben ;))

@filip326
Copy link
Collaborator Author

image
(auf Deutsch: Beweis)

@chfuchte
Copy link
Collaborator

ja ok

@EinsKatze
Copy link
Collaborator

EinsKatze commented Jan 18, 2024

npm usually gets installed when installing NodeJS. (So why install & switch to yarn?)
btw what would be the benefit of using yarn instead of npm?

@Mickhat
Copy link
Owner

Mickhat commented Jan 24, 2024

habbit i guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file invalid This doesn't seem right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants