Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump follow-redirects from 1.15.2 to 1.15.5 #78

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 12, 2024

Bumps follow-redirects from 1.15.2 to 1.15.5.

Commits
  • b1677ce Release version 1.15.5 of the npm package.
  • d8914f7 Preserve fragment in responseUrl.
  • 6585820 Release version 1.15.4 of the npm package.
  • 7a6567e Disallow bracketed hostnames.
  • 05629af Prefer native URL instead of deprecated url.parse.
  • 1cba8e8 Prefer native URL instead of legacy url.resolve.
  • 72bc2a4 Simplify _processResponse error handling.
  • 3d42aec Add bracket tests.
  • bcbb096 Do not directly set Error properties.
  • 192dbe7 Release version 1.15.3 of the npm package.
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.5.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.5)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from Mickhat as a code owner January 12, 2024 19:31
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 12, 2024
@filip326
Copy link
Collaborator

Why is the package-lock even in the repo?

@filip326
Copy link
Collaborator

I taught we are using yarn, aren't we?

@chfuchte
Copy link
Collaborator

simply because it's not in the gitignore

@chfuchte
Copy link
Collaborator

no. we are using npm since we (you and me) started using yarn (the superior node package manager) in 2023 and the project started in 2022

@filip326
Copy link
Collaborator

no. we are using npm since we (you and me) started using yarn (the superior node package manager) in 2023 and the project started in 2022

In this project we always used yarn

@filip326
Copy link
Collaborator

I can prove it since the yarn.lock is mentioned by mickhat in the gitignore 2 year ago already

no. we are using npm since we (you and me) started using yarn (the superior node package manager) in 2023 and the project started in 2022

In this project we always used yarn

@chfuchte
Copy link
Collaborator

https://github.com/Mickhat/FloBot/blob/master/Dockerfile

take a closer look in the actions, the package.json and the Dockerfile ;)

@filip326
Copy link
Collaborator

Maybe we should "unignore" the yarn lock and ignore the package-lock, since we are using yarn

Copy link
Collaborator

@chfuchte chfuchte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in any case. the package-lock.json is on github and is required for the actions to work properly

@filip326
Copy link
Collaborator

https://github.com/Mickhat/FloBot/blob/master/Dockerfile

take a closer look in the actions, the package.json and the Dockerfile ;)

I still think we should use yarn instead of npm, also in the Dockerfile.

Maybe a task for @oglimmer ?

@chfuchte
Copy link
Collaborator

still. that's a discussion for the issue not the PR of dependabot

Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 3, 2024

Superseded by #102.

@dependabot dependabot bot closed this Jul 3, 2024
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/follow-redirects-1.15.5 branch July 3, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants