added Spanish (ES) and Japanese(JA) translation files. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IndigoWizard
added
documentation 📃
IndigoWizard
suggested changes
Oct 30, 2019
There was a problem hiding this comment.
Hello, your contribution is welcome, it just got some issues:
-
It seems the badges are not working any more on both translated versions, some part of the badge's links were translated which is not supposed to be done as these are links!
-
The Markdown format of the text was affected and the formatting was messed up in some lines, please check in comparison to the original README.md version.
-
Both JA & ES readme files were uploaded to the repo's root, please moves the files in question to the dedicated folder /translations
How to change a file location? Rename the file at a different path:
Current path: Hacktoberfest-2k19/README_JA.md
Correct path: Hacktoberfest-2k19/translations/_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have a look, I've added Japanese and Spanish Translation .md files