1.0beta3 #439
Merged
1.0beta3 #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![code-review-doctor[bot]](https://avatars.githubusercontent.com/in/83430?s=60&v=4){kind=small}
| street = models.CharField(_("Street"), max_length=55, blank=True, default="") | ||
| city = models.CharField(_("City"), max_length=255, blank=True, default="") | ||
| state = models.CharField(_("State"), max_length=255, blank=True, default="") | ||
| postcode = models.CharField(_("Post/Zip-code"), max_length=64, blank=True, default="") | ||
| postcode = models.CharField( | ||
| _("Post/Zip-code"), max_length=64, blank=True, default="" |
There was a problem hiding this comment.
null=True on a string field causes inconsistent data types because the value can be either str or None. This adds complexity and maybe bugs, but can be solved by replacing null=True with default="".
| @@ -240,4 +240,4 @@ | |||
| SECURE_HSTS_PRELOAD = True | |||
| SECURE_CONTENT_TYPE_NOSNIFF = True | |||
|
|
|||
| DEFAULT_AUTO_FIELD='django.db.models.AutoField' | |||
| DEFAULT_AUTO_FIELD = "django.db.models.AutoField" | |||
There was a problem hiding this comment.
Suggested change
| DEFAULT_AUTO_FIELD = "django.db.models.AutoField" | |
| DEFAULT_AUTO_FIELD = "django.db.models.AutoField" | |
| SECURE_SSL_REDIRECT = os.getenv("SECURE_SSL_REDIRECT_ENABLED") != "False" | |
| SESSION_COOKIE_SECURE = os.getenv("SESSION_COOKIE_SECURE_ENABLED") != "False" |
Consider setting SECURE_SSL_REDIRECT to prevent users from accessing the website over HTTP. HTTP connections allow bad actors to intercept passwords and session cookies, and to easily change the contents of the request or response.
Consider setting SESSION_COOKIE_SECURE to prevent cookies from being sent over non HTTPS connections. Cookies sent over insecure HTTP connections can be intercepted by hackers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.