Skip to content
This repository has been archived by the owner on Oct 14, 2020. It is now read-only.

Detect WAR location properly in Maven #268

Open
chyt opened this issue Feb 11, 2019 · 1 comment
Open

Detect WAR location properly in Maven #268

chyt opened this issue Feb 11, 2019 · 1 comment
Labels
bug Something isn't working maven Issues for boost-maven

Comments

@chyt
Copy link
Contributor

chyt commented Feb 11, 2019

The way we are currently finding the location of the WAR is not robust and only works for the default app name configuration: https://github.com/OpenLiberty/boost/blob/cac4650c89dff1806ddf1721a853a446e4234307/boost-maven/boost-maven-plugin/src/main/java/io/openliberty/boost/maven/liberty/LibertyPackageMojo.java#L181,L186

Instead, I believe we should be evaluating the webAppDirectory parameter from the maven-war-plugin. If the parameter is not set then we should default to that parameter's default value by using project.getBuild().getFinalName().

@chyt chyt added maven Issues for boost-maven bug Something isn't working labels Feb 11, 2019
@scottkurz
Copy link
Contributor

@chyt do you think #387 addresses this at the current level of support? Or do you think we still should make a change?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working maven Issues for boost-maven
Projects
None yet
Development

No branches or pull requests

2 participants