Skip to content

Commit

Permalink
Modified documentation, fixed _get_note_name
Browse files Browse the repository at this point in the history
  • Loading branch information
MicroTransactionsMatterToo committed Aug 31, 2017
1 parent bc31680 commit 1117319
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion midisnake/events.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def _decode_leftright(data: int) -> str:
return "right"
elif data < 64:
return "left"
elif data == 127:
elif data == 64:
return "center"
else:
raise ValueError("Balance value {} was outside of valid range of 0-127".format(data))
Expand Down Expand Up @@ -143,7 +143,16 @@ def get_note_name(data: int) -> str:
Returns:
str: Note name
Raises:
ValueError: This is raised when the given value is smaller than 0, or larger than 127 (maximum value allowed
in specification)
"""
# Raise ValueError if value is too large or too small
if data > 127:
raise ValueError("Note values cannot be larger than 127 (0x7F). Given value was {0} ({0:x})".format(data))
if data < 0:
raise ValueError("Note values cannot be smaller than 0 (0x00). Given value was {0} ({0:x})".format(data))
if data in range(0, 12):
return note_values[data]
else:
Expand Down

0 comments on commit 1117319

Please sign in to comment.