You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The cmake target "cryptoauth" does not declare its headers with target_include_directories, so other projects that use this library do not automatically pick up all of the needed header paths when linking.
To Reproduce
Create a new cmake project that uses this library as a submodule. Create a small executable and link with target_link_libraries(foo PUBLIC cryptoauth).
As the needed header dirs are not exported with the cryptoauth target, the build will fail with
fatal error: cryptoauthlib.h: No such file or directory
Expected behavior
Clean build
Additional context
Changing include_directories to target_include_directories at cryptoauthlib/lib/CMakeLists.txt
seems to work, the headers are correctly propagated to another exe that links to cryptoauth and it builds without manually setting the header search path. May also need to change something for OPENSSL support / L326 if ATCA_OPENSSL is set.
The text was updated successfully, but these errors were encountered:
Hi @jacobschloss
Thanks for sharing your observations.
We shall check this and review for the required changes.
Since the downstream sources needs to be in sync, we shall absorb it as per planned our planned release process
Describe the bug
The cmake target "cryptoauth" does not declare its headers with target_include_directories, so other projects that use this library do not automatically pick up all of the needed header paths when linking.
To Reproduce
Create a new cmake project that uses this library as a submodule. Create a small executable and link with target_link_libraries(foo PUBLIC cryptoauth).
As the needed header dirs are not exported with the cryptoauth target, the build will fail with
fatal error: cryptoauthlib.h: No such file or directory
Expected behavior
Clean build
Additional context
Changing include_directories to target_include_directories at cryptoauthlib/lib/CMakeLists.txt
cryptoauthlib/lib/CMakeLists.txt
Line 309 in 405d831
seems to work, the headers are correctly propagated to another exe that links to cryptoauth and it builds without manually setting the header search path. May also need to change something for OPENSSL support / L326 if ATCA_OPENSSL is set.
The text was updated successfully, but these errors were encountered: