Refactoring StorageHelper class #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
changed the title
dhei
reviewed
Oct 29, 2018
| mSQLiteOpenHelper = helper; | ||
| String[] getColumnNames() { | ||
|
|
||
| // TODO: Below line doesn't look efficient to get column names. Could use "PRAGMA table_info(table-name)" to avoid getting all data back from database just to get column names. |
There was a problem hiding this comment.
How about let's do this TODO now? 😄
There was a problem hiding this comment.
This is used only in unit tests we could just remove the comment
dhei
reviewed
Oct 29, 2018
| persistence.close(); | ||
| } | ||
|
|
||
| /* There is a error log. */ |
There was a problem hiding this comment.
Please fix all occurrence in this file
guperrot
reviewed
Oct 29, 2018
| Constants.loadFromContext(sContext); | ||
| } | ||
|
|
||
| private static int getCursorSize(Cursor cursor) { |
There was a problem hiding this comment.
Can use cursor.getCount() now that we removed a layer.
guperrot
reviewed
Oct 29, 2018
| long databaseId = mDatabaseStorage.put(contentValues); | ||
| long databaseId = mDatabaseManager.put(contentValues); | ||
| if (databaseId == -1) { | ||
| AppCenterLog.warn(LOG_TAG, "Failed to store a log to the Persistence database for log type " + log.getType() + "."); |
There was a problem hiding this comment.
Need to throw PersistenceException
| try { | ||
| Cursor cursor = mDatabaseManager.getCursor(builder, new String[]{group}, true); | ||
| count = cursor.getCount(); | ||
| cursor.close(); |
| String[] selectionArgs = new String[]{value.toString()}; | ||
| Cursor cursor = getCursor(builder, selectionArgs, false); | ||
| ContentValues values = cursor.moveToFirst() ? buildValues(cursor) : null; | ||
| cursor.close(); |
| mSQLiteOpenHelper = helper; | ||
| String[] getColumnNames() { | ||
|
|
||
| // TODO: Below line doesn't look efficient to get column names. Could use "PRAGMA table_info(table-name)" to avoid getting all data back from database just to get column names. |
There was a problem hiding this comment.
This is used only in unit tests we could just remove the comment
|
|
||
| /* groupCount should be <= 9. */ | ||
| final int groupCount = 4; | ||
| final int groupCount = 1; |
dhei
approved these changes
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HasCHANGELOG.mdbeen updated?