Add priority to database persistence #853
Conversation
| /** | ||
| * An event can be lost due to low bandwidth or disk space constraints. | ||
| */ | ||
| public static final int PERSISTENCE_NORMAL = 0x01; |
There was a problem hiding this comment.
Maybe we should use a bitwise shift like in iOS?
| public static final int PERSISTENCE_NORMAL = 0x01; | |
| public static final int PERSISTENCE_NORMAL = 1 << 0; |
There was a problem hiding this comment.
I'd prefer 0x01. This is Java convention so we can keep hexadecimal number here.
There was a problem hiding this comment.
Personally it's more readable for me too. Admittedly it's explicitly different than how we have it in iOS but if we're following language conventions then I don't mind.
There was a problem hiding this comment.
0x01 is more readable indeed.
| @@ -191,15 +208,17 @@ public boolean onUpgrade(SQLiteDatabase db, int oldVersion, int newVersion) { | |||
| * @param logJ The JSON string for a log. | |||
| * @param targetToken target token if the log is common schema. | |||
| * @param targetKey project identifier part of the target token in clear text. | |||
| * @param priority priority. | |||
There was a problem hiding this comment.
Let's align with other parameters - first letter case and article
| @@ -765,14 +768,26 @@ public void getLogsException() throws PersistenceException, JSONException { | |||
| } | |||
| } | |||
|
|
|||
| @NonNull | |||
| private ContentValues getContentValues(DatabasePersistence persistence, String group) { | |||
There was a problem hiding this comment.
Can you move this method to the bottom or top of the file?
| /** | ||
| * An event can be lost due to low bandwidth or disk space constraints. | ||
| */ | ||
| public static final int PERSISTENCE_NORMAL = 0x01; |
There was a problem hiding this comment.
I'd prefer 0x01. This is Java convention so we can keep hexadecimal number here.
|
|
Please have a look at our guidelines for contributions and consider the following before you submit the PR:
CHANGELOG.mdbeen updated?Description
Add priority field to persistence.