-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flags to common schema payload #857
Conversation
|
||
/* Verify reset of epoch/seq. */ | ||
/* Verify flags and reset of epoch/seq. */ | ||
assertEquals(new Long(PERSISTENCE_NORMAL), log4.getFlags()); | ||
assertEquals((Long) 1L, log4.getExt().getSdk().getSeq()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use only one way for casting numbers in asserts like this. For example
assertEquals((Long) 1L, log4.getExt().getSdk().getSeq()); | |
assertEquals(Long.valueOf(1), log4.getExt().getSdk().getSeq()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
@@ -92,18 +95,18 @@ public void enqueueConvertedLogs() { | |||
when(originalLog.getTransmissionTargetTokens()).thenReturn(new HashSet<>(Collections.singletonList("t1"))); | |||
|
|||
/* Mock a log. */ | |||
CommonSchemaLog log1 = mock(CommonSchemaLog.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is not necessarily in scope for this PR, but the enqueueConvertedLogs
test is doing a lot. I'd like to see it split up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how to split as we need to test reset the sequence of epoch and seq in the same test.
Please have a look at our guidelines for contributions and consider the following before you submit the PR:
CHANGELOG.md
been updated?Description
A few sentences describing the overall goals of the pull request.
Related PRs or issues
List related PRs and other issues.
Misc
Add what's missing, notes on what you tested, additional thoughts or questions.