Add flags to common schema payload #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
Oct 31, 2018
|
|
||
| /* Verify reset of epoch/seq. */ | ||
| /* Verify flags and reset of epoch/seq. */ | ||
| assertEquals(new Long(PERSISTENCE_NORMAL), log4.getFlags()); | ||
| assertEquals((Long) 1L, log4.getExt().getSdk().getSeq()); |
There was a problem hiding this comment.
Let's use only one way for casting numbers in asserts like this. For example
Suggested change
| assertEquals((Long) 1L, log4.getExt().getSdk().getSeq()); | |
| assertEquals(Long.valueOf(1), log4.getExt().getSdk().getSeq()); |
thyeggman
approved these changes
Oct 31, 2018
| @@ -92,18 +95,18 @@ public void enqueueConvertedLogs() { | |||
| when(originalLog.getTransmissionTargetTokens()).thenReturn(new HashSet<>(Collections.singletonList("t1"))); | |||
|
|
|||
| /* Mock a log. */ | |||
| CommonSchemaLog log1 = mock(CommonSchemaLog.class); | |||
There was a problem hiding this comment.
I know this is not necessarily in scope for this PR, but the enqueueConvertedLogs test is doing a lot. I'd like to see it split up.
There was a problem hiding this comment.
Not sure how to split as we need to test reset the sequence of epoch and seq in the same test.
guperrot
changed the base branch from
feature/priority-channel
to
feature/priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at our guidelines for contributions and consider the following before you submit the PR:
CHANGELOG.mdbeen updated?Description
A few sentences describing the overall goals of the pull request.
Related PRs or issues
List related PRs and other issues.
Misc
Add what's missing, notes on what you tested, additional thoughts or questions.