Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event persistence priority #874

Merged
merged 91 commits into from
Nov 9, 2018
Merged

Event persistence priority #874

merged 91 commits into from
Nov 9, 2018

Conversation

guperrot
Copy link
Member

@guperrot guperrot commented Nov 9, 2018 •
edited
Loading

Please have a look at our guidelines for contributions and consider the following before you submit the PR:

  • Has CHANGELOG.md been updated?
  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you add unit tests?
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

The entire feature work to merge in develop, everything been reviewed and tested already.
Changelog and version change is on #874

jaeklim and others added 30 commits October 24, 2018 16:06
@jaeklim
Remove DatabaseStorage inner class from StorageHelper class
e162ce5
@jaeklim
Remove in-memory database
fd6e9e4
@jaeklim
Refactor StorageHelperAndroidTest class for database manager
cd62175
@jaeklim
Refactor PreferencesStorage helper class
1739e9f
@jaeklim
Refactor InternalStorage helper class
fe00dc1
@jaeklim
Refactor storage helper test classes
74b494b
@jaeklim
Clean up after refactoring
badcc4c
@jaeklim
Refactoring getScanner and getCursor with one unit test disabled
7754e05
@jaeklim
Fix broken unit tests
4c79bca
@MatkovIvan
Remove scanner class
ada48ee
@MatkovIvan
Restore thread safety
bc992de
@MatkovIvan
Fix tests
8a74659
@MatkovIvan
Fix coverage
b047596
@MatkovIvan
Fix lint issues
5842ca1
@MatkovIvan
Fix test app build with jcenter flavor
c039c7b
@guperrot
Move test only utils from SDK to tests and use finally for close
1236ea8
@guperrot
Merge pull request #851 from Microsoft/feature/refactor-storage-helper
a35d53f 
Refactoring StorageHelper class
@guperrot
Add priority to database persistence
9f6c948
@guperrot
Fix coverage
4af15db
@guperrot
Fix most warnings in channel
90e72bc
@guperrot
Fix some debug log messages
55e2d86
@guperrot
Simplify state change detection and fix null check at same time
908b4bb 
In ingestion callbacks used by channel.
@guperrot
Address feedbacks
a3a1160
@jaeklim
Merge pull request #853 from Microsoft/feature/priority-database
ca051cf 
Add priority to database persistence
@jaeklim
Merge branch 'feature/priority' into feature/priority-channel
a5c0dc3
@guperrot
Merge pull request #854 from Microsoft/feature/priority-channel
9710aa9 
Fix warnings in channel
@guperrot
Add flags to enqueue item, use critical for crash, defaults otherwise
9e44643
@guperrot
Forward flags to one collector channel listener
8410ae0
@guperrot
Handle flags in enqueueLog and fix persistence flags processing
429bd60
@guperrot
Address feedbacks
6a5336c
guperrot and others added 26 commits November 2, 2018 13:00
@guperrot
Merge branch 'feature/priority-develop' into feature/ui-flags
2d172cd
@guperrot
Merge pull request #862 from Microsoft/feature/ui-flags
42e4884 
Add UI to test trackEvent with flags
@guperrot
Rate limit toasts in event page
6df48ca
@guperrot
Merge remote-tracking branch 'origin/develop' into feature/priority
756a7c6
@guperrot
Mention UI tests in pull request template now that they are fixed again
97c15a7
@guperrot
Merge pull request #864 from Microsoft/feature/ui-multiple-logs
47c65bd 
Send multiple events at once in UI
@guperrot
Merge remote-tracking branch 'origin/develop' into feature/priority-d…
7adc916 
…evelop
@dhei
Merge pull request #866 from Microsoft/feature/priority-develop
862c67d 
Merge develop to priority
@guperrot
Rename default flags
d2899ff
@dhei
Merge pull request #868 from Microsoft/feature/rename-flags
19600fc 
Rename default flags
@MatkovIvan
Add flags to trackEvent(String, Map)
9f2789a
@MatkovIvan
Fix tests
c3a4880
@MatkovIvan
Update test app
8bd86b4
@MatkovIvan
Create index on priority table
156001f
@MatkovIvan
Fix tests
e219e7b
@MatkovIvan
Merge pull request #870 from Microsoft/feature/priority-track-event-f…
ef78840 
…lags-api

Add flags to trackEvent(String, Map)
@MatkovIvan
Add flags to AnalyticsTransmissionTarget.trackEvent(String, Map)
292f608
@MatkovIvan
Update demo app
4f49c6a
@MatkovIvan
Move index creation to create/upgrade callbacks
d301eba
@guperrot
Update Javadoc for flags
7e1a08a
@guperrot
Fix UI for track event with name, critical, and no property
190b8a3 
Uses null typed properties in that case like documented.
@guperrot
Update database unit tests to actually check eviction behavior
aa06618 
While still dealing with index having variable sizes between runs.
@guperrot
Fix warning
97a1bcf
@guperrot
Merge pull request #872 from Microsoft/feature/priority-track-event-f…
d13f031 
…lags-api

 Add flags to AnalyticsTransmissionTarget.trackEvent(String, Map)
@guperrot
Grammar
eb70612
@guperrot
Merge pull request #871 from Microsoft/feature/priority-index
98899f2 
Create index on priority table
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 98899f2 on feature/priority into a152e73 on develop.

@guperrot guperrot merged commit 74f2eb5 into develop Nov 9, 2018
@guperrot guperrot deleted the feature/priority branch November 9, 2018 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhei dhei dhei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@guperrot @coveralls @dhei @jaeklim @MatkovIvan