Add UI to test trackEvent with flags #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guperrot
force-pushed
the
feature/ui-flags
branch
from
7597881
to
67785a9
Compare
|
The number of logs slider will come in a separate PR. |
jaeklim
previously approved these changes
Nov 2, 2018
| return Flags.PERSISTENCE_CRITICAL; | ||
|
|
||
| case INVALID: | ||
| return Flags.PERSISTENCE_CRITICAL + 1; |
There was a problem hiding this comment.
Let's use some bigger number if you would like to.
guperrot
changed the base branch from
feature/track-event-flags
to
feature/priority
|
Test flakiness comes from develop, will fix it separately. |
iamclement
approved these changes
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at our guidelines for contributions and consider the following before you submit the PR:
CHANGELOG.mdbeen updated?Description