Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix push foreground listener after re-enabling push service #881

Merged
merged 6 commits into from
Nov 19, 2018

Conversation

MatkovIvan
Copy link
Contributor

  • Has CHANGELOG.md been updated?
  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you add unit tests?
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?
  • Did you check UI tests on the sample app? They are not executed on CI.

Description

  1. Start Sasquatch
  2. Go to settings
  3. Disable push
  4. Restart app
  5. Go to settings
  6. Enable push
  7. Stay on settings screen, do not turn screen off and on
  8. Push => no dialog

Reason is that mActivity is null in that case for Push class, we need to store/update mActivity reference even when Push is disabled so that it's ready at enabled time.

@coveralls
Copy link

coveralls commented Nov 15, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 317e722 on fix/push-activity into c545e57 on develop.

@guperrot
Copy link
Member

There was a need for the post command, need to find history before I can elaborate.

Copy link
Member

@guperrot guperrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behavior ok, have a comment on unit test.

@MatkovIvan MatkovIvan closed this Nov 19, 2018
@MatkovIvan MatkovIvan reopened this Nov 19, 2018
@guperrot guperrot merged commit da30acb into develop Nov 19, 2018
@guperrot guperrot deleted the fix/push-activity branch November 19, 2018 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants