Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity.SignOut: Apply code convention on instance + synchronized + post background #977

Merged
merged 3 commits into from
Mar 5, 2019

Conversation

guperrot
Copy link
Member

@guperrot guperrot commented Mar 4, 2019

Change warning to error message for cannot sign out and update wording.

Please have a look at our guidelines for contributions and consider the following before you submit the PR:

  • Has CHANGELOG.md been updated?
  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you add unit tests?
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?
  • Did you check UI tests on the sample app? They are not executed on CI.

Description

Missed feedbacks last time on sign out.

Change warning to error message for cannot sign out and update wording.
@guperrot
Copy link
Member Author

guperrot commented Mar 4, 2019

Variables always accessed in background thread do not require extra synchronization.

@guperrot guperrot changed the title Apply code convention on instance + synchronized + post background Identity.SignOut: Apply code convention on instance + synchronized + post background Mar 4, 2019
@guperrot guperrot merged commit 5f11505 into feature/identity Mar 5, 2019
@guperrot guperrot deleted the feature/signout-polish branch March 5, 2019 03:51
@MatkovIvan
Copy link
Contributor

@guperrot
Copy link
Member Author

guperrot commented Mar 5, 2019

@guperrot As I said in the comment to that PR, mSignInDelayed variable can be accessed from the UI thread too.

AppCenter-SDK-Android/sdk/appcenter-identity/src/main/java/com/microsoft/appcenter/identity/Identity.java

Line 233 in 12a347d

if (mSignInDelayed) {

We are getting rid of that with the new bug anyway but can be fixed simply via #984 while keeping the pattern of using post inside the instance method.

@guperrot guperrot mentioned this pull request Mar 5, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants