-
Notifications
You must be signed in to change notification settings - Fork 123
Enable ServerTelemetryChannel in .net core by the default #530
Conversation
this.ValidateBasicDependency(assemblyName, "/Home/About/5", InProcessServer.UseApplicationInsights); | ||
const string RequestPath = "/Home/About/5"; | ||
|
||
using (var server = new InProcessServer(assemblyName)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason of moving this line (using (var server = new InProcessServer(assemblyName))) from base class to each of the subclasses?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was in base class only for dependencies, but for requests and exceptions, it was out of it in individual cases - i moved it out of here for dependencies as well to be more consistent in all methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add changelog.md to indicate the new default channel.
Minor questions in comments as well.
- Move the fake endpoint to a constant.
- Is there a reason of moving this line (using (var server = new InProcessServer(assemblyName))) from base class to each of the subclasses?
var machineName = Environment.GetEnvironmentVariable("COMPUTERNAME"); | ||
this.url = "http://" + machineName + ":" + random.Next(5000, 14000).ToString(); | ||
this.backChannel = this.Start(assemblyName); | ||
|
||
this.listener = new TelemetryHttpListenerObservable("http://localhost:4001/v2/track/"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets make this a constant.
Due to some reason build is not triggered automatically! Can you trigger one against this PR. ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please trigger 10-20 builds to confirm race condition test failures are resolved before merge.
Hello guys, thank you for enabling of ServerTelemetryChannel in NETCOREAPP2_0, but how to access it now? in non-Core it is possible like this:
how to get the same in core? |
@KEMBL Can you retrieve channel like this hostingEngine.Services.GetService()) ? |
Enable ServerTelemetryChannel in .net core by the default