Fix bugs for 1.0.1 #353
Merged
Fix bugs for 1.0.1 #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AutoCollection/HttpDependencies.ts
Outdated
| }; | ||
| } | ||
| https.request = (options, ...requestArgs: any[]) => { | ||
| const request: http.ClientRequest = originalHttpsRequest.call( |
There was a problem hiding this comment.
isn't it exactly the same as for http.request? Would it make sense to move it to a method and just pass originalHttpsRequest/originalRequest object?
There was a problem hiding this comment.
Nope, the base functions take different numbers of arguments 😄
There was a problem hiding this comment.
I do really dislike the duplication though.. For what its worth, it was already duplicated like this before the changes
There was a problem hiding this comment.
Actually scratch that, I think this can be cleanly de-duplicated. Will change
KamilSzostak
approved these changes
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #352, #351, #349, #348 and prepare a 1.0.1 release.