Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCR: Add Slot property to Prompt class #5091

Closed
8 tasks
tomlm opened this issue Oct 2, 2018 · 3 comments
Closed
8 tasks

DCR: Add Slot property to Prompt class #5091

tomlm opened this issue Oct 2, 2018 · 3 comments
Labels
feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team.

Comments

@tomlm
Copy link
Contributor

tomlm commented Oct 2, 2018

Issue

Currently prompt classes require the caller to take the output of a prompt and assign it to a slot. This causes the following:

  • on a waterfall, the next step needs to collect the slot value and save it
  • it pushes a code requirement into the consumption of the Prompt.

Proposed change

If we change the prompt class to have a property called "Slot" it can be configured to automatically "fill the slot" without requiring code behind.

Component Impact

Base prompt class in each SDK

Customer Impact

Should be additive, if the property is set people can start using it.

Tracking Status

Dotnet SDK

  • PR
  • Merged

Javascript SDK

  • PR
  • Merged

Samples

  • PR
  • Merged

Docs

  • PR
  • Merged

Java SDK - n/a Dialogs library doesn't exist on java yet.
Python SDK - n/a Dialogs library doesn't exist on python yet.

[dcr]

@Stevenic
Copy link
Contributor

Stevenic commented Oct 2, 2018

The issue is, the Prompt doesn't have access to the memory where the value needs to be stored. Each dialog has its own isolated storage which it uses to accumulate values returned by calling prompts or other dialogs. I haven't figured out a good workaround for this as everything I've thought of either violates the underlying stack model or comes with its own side effects.

@tomlm
Copy link
Contributor Author

tomlm commented Oct 2, 2018

I think we would have to create something like this:

class DialogSlotResult : DialogResult
{ 
     public string Slot 
    public object Result
}

@gabog gabog added needs-triage The issue has just been created and it has not been reviewed by the team. feature-request A request for new functionality or an enhancement to an existing one. labels Aug 13, 2020
@gabog
Copy link
Contributor

gabog commented Aug 13, 2020

I think this issue is pretty old now and does not apply to the current state of the SDK, closing.

@gabog gabog closed this as completed Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team.
Projects
None yet
Development

No branches or pull requests

4 participants