#935 - added the ability to input App insights manually #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corinagum
reviewed
Nov 19, 2018
| private onLearnMoreServicesAnchor = () => { | ||
| this.props.onAnchorClick('https://aka.ms/bot-framework-emulator-services'); | ||
| private onAnchorClick = (event: MouseEvent<HTMLAnchorElement>): void => { | ||
| this.props.onAnchorClick(event.currentTarget.dataset.href); |
There was a problem hiding this comment.
These will have to be modified to buttons, since they no longer contain href tags they are semantically no longer links. As is, they are not keyboard accessible and will not be read out by narrator.
There was a problem hiding this comment.
Pressed enter too soon -- should I file a bug to comb over all of these instances to do an app-wide fix?
There was a problem hiding this comment.
I don't like the idea of using buttons for links. Links are semantically correct HTML for their use, buttons are not.
We should evaluate whether or not it's necessary to require the main process to open an external link. This could be legacy Electron functionality. We should be able to use:
<a href="https://someurl" target="_blank">A Happy link</a>and be done.
Pull Request Test Coverage Report for Build 1389
💛 - Coveralls |
…ramework-Emulator into jwilaby/#935-app-insights
tonyanziano
previously approved these changes
Nov 19, 2018
packages/app/client/src/ui/dialogs/connectServicePromptDialog/connectServicePromptDialog.tsx
Outdated
Show resolved
Hide resolved
...ent/src/ui/shell/explorer/servicesExplorer/connectedServiceEditor/connectedServiceEditor.tsx
Outdated
Show resolved
Hide resolved
tonyanziano
approved these changes
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #935