Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulator - add support for app insights service configuration #935

Closed
vishwacsena opened this issue Sep 27, 2018 · 8 comments · Fixed by #1108
Closed

Emulator - add support for app insights service configuration #935

vishwacsena opened this issue Sep 27, 2018 · 8 comments · Fixed by #1108
Assignees
Labels
Approved Approved by the Triage team Design Design Team issue P0 Must Fix. Release-blocker

Comments

@vishwacsena
Copy link
Contributor

Bot file supports keeping track of app insights service configuration.

Emulator does not provide any affordance at all to manage this today (both through the azure login flow as well as through manual mode).

Filing this ticket to track the work for emulator to support app insights service configuration.

@vishwacsena vishwacsena added Approved Approved by the Triage team Design Design Team issue v4 labels Sep 27, 2018
@vishwacsena vishwacsena removed the v4 label Oct 9, 2018
@sgellock sgellock added the v4.2 label Oct 9, 2018
@sgellock sgellock added the P0 Must Fix. Release-blocker label Oct 31, 2018
@mewa1024
Copy link

mewa1024 commented Nov 15, 2018

@vishwacsena
Can you confirm that this is the right flow? Using the QnA Maker/LUIS/Dispatch flow as a model:

Modals for adding a Service X when:
(A) user has signed into Azure, and user has a Service X service - user picks from a list
(C) user has not signed into Azure - gets modal to sign in or connect manually
(D) user adds app by entering required fields - modal with fields to enter manually

And these are the fields required (according to the doc for msbot connect appinsights):

  • Name (defaults to serviceName)
  • Azure Tenant id (either GUID or xxx.onmicrosoft.com)
  • Azure Subscription Id
  • Azure resource group name
  • Azure service name
  • App Insights Instrumentation Key
  • (OPTIONAL) App Insights Application Id

Comps of the modals are here:
https://microsoft-fuse-design.invisionapp.com/d/#/projects/prototypes/14863139 (look in App Insights section)

Other questions:

This is the order for the Add menu:
image
(Adding the word "Add" in front of all the service names because participants in the user study mistakenly thought that clicking on the service name navigated to the service.)

@vishwacsena
Copy link
Contributor Author

@mewa1024 - this is great and yes following along the patterns established by the current flows for LUIS, QnA and dispatch is the right model for other service types. Yes, we should have pointers to doc pages for the respective services. We can have it be application insights for now and update the copy later if needed.

@mewa1024
Copy link

mewa1024 commented Nov 16, 2018

@vishwacsena Cool. Assigning to Justin. @justinwilaby Designs are on Invision. The links are not ready yet, and I will set up aka links next week.

@mewa1024 mewa1024 assigned justinwilaby and mewa1024 and unassigned mewa1024 Nov 16, 2018
@mewa1024
Copy link

@justinwilaby I updated the designs with the links:
Link: https://aka.ms/bot-framework-emulator-create-appinsights
Link: https://aka.ms/bot-framework-emulator-appinsights-docs
Link: https://aka.ms/bot-framework-emulator-appinsights-keys

Updates to the designs are on Invision and also copied below:

image

image

image

@mewa1024
Copy link

@justinwilaby I have found a few typos in the comps and just corrected them. Sorry about this:

  • changed the wording in the Azure picker modal from "Select a resource below to your resource's information in your bot file or connect to an Application Insights resource manually" to "Select a resource below or connect to an Application Insights resource manually."

  • changed the wording in the Azure picker modal from "Create a new Application Insights service." to "Create a new Application Insights resource."

image

  • changed the wording in the not-signed-in-yet modal from "Alternatively, you can connect to an Azure Application Insights resource manually with the app ID, version, and authoring key" to "Alternatively, you can connect to an Azure Application Insights resource manually. "

image

@mewa1024 mewa1024 removed their assignment Nov 20, 2018
justinwilaby pushed a commit that referenced this issue Nov 20, 2018
#935 - added the ability to input App insights manually
@mewa1024
Copy link

mewa1024 commented Dec 7, 2018

@justinwilaby similar issues as #934.
In the link to the Azure portal,

  • please exclude the word "the" from the link.
  • Please remove the words "App Insights " altogether, so the text should be "the Azure portal." with "Azure portal" as the linked text.
  • Please add a period to the end of the sentence

Please use semibold for all the links (the accessibility people require a font weight change for links in text, so this should be the style throughout the Emulator.

Also, the deep link to App Insights is not working.

@mewa1024 mewa1024 reopened this Dec 7, 2018
@mewa1024
Copy link

mewa1024 commented Dec 7, 2018

@justinwilaby One more thing, the modal is looking for "Azure Subscription Key" instead of "Azure Subscription ID". This means the modal is showing the field as blank, even though the .bot file has an entry for "subscriptionId":

image

@tonyanziano
Copy link
Contributor

Addressed in #1160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Approved by the Triage team Design Design Team issue P0 Must Fix. Release-blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants