Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility links fix #1121

Merged
merged 7 commits into from Nov 21, 2018
Merged

Accessibility links fix #1121

merged 7 commits into from Nov 21, 2018

Conversation

corinagum
Copy link
Contributor

Fixes #1096 , removes remote call to open links on main side.
Minor styling fix for Bot Settings Editor checkbox

@coveralls
Copy link

coveralls commented Nov 21, 2018 •
edited

Pull Request Test Coverage Report for Build 1436

  • 7 of 14 (50.0%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 56.122%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/client/src/ui/dialogs/azureLoginPromptDialog/azureLoginPromptDialogContainer.ts 0 1 0.0%
packages/app/client/src/data/sagas/servicesExplorerSagas.ts 1 3 33.33%
packages/app/main/src/appMenuBuilder.ts 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
packages/app/client/src/ui/editor/welcomePage/welcomePageContainer.ts 1 58.33%
Totals Coverage Status
Change from base Build 1432: 0.04%
Covered Lines: 4528
Relevant Lines: 7263
💛 - Coveralls

justinwilaby
justinwilaby previously approved these changes Nov 21, 2018
View reviewed changes
Copy link
Contributor

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@corinagum
Copy link
Contributor Author

ping @justinwilaby @tonyanziano

@justinwilaby justinwilaby merged commit 368e1dc into master Nov 21, 2018
@justinwilaby justinwilaby deleted the corinagum/1096-2 branch November 21, 2018 22:31
This was referenced Nov 5, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyanziano tonyanziano tonyanziano approved these changes

@justinwilaby justinwilaby justinwilaby left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessibility: "How to build a bot" section of Welcome Page [Regression]
4 participants
@corinagum @coveralls @justinwilaby @tonyanziano