Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves #1159 - Service links cause emulator to stop #1160

Merged
merged 1 commit into from Dec 10, 2018
Merged

resolves #1159 - Service links cause emulator to stop #1160

merged 1 commit into from Dec 10, 2018

Conversation

justinwilaby
Copy link
Contributor

No description provided.

tonyanziano
tonyanziano approved these changes Dec 10, 2018
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: :shipit:

@justinwilaby justinwilaby merged commit 2cda763 into master Dec 10, 2018
@justinwilaby justinwilaby deleted the jwilaby/#1159-new-service-links branch December 10, 2018 18:25
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1521

  • 8 of 10 (80.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 57.329%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/client/src/data/sagas/servicesExplorerSagas.ts 8 10 80.0%
Files with Coverage Reduction New Missed Lines %
packages/app/client/src/data/sagas/servicesExplorerSagas.ts 1 70.79%
Totals Coverage Status
Change from base Build 1519: 0.1%
Covered Lines: 4801
Relevant Lines: 7544
💛 - Coveralls

@tonyanziano tonyanziano mentioned this pull request Dec 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyanziano tonyanziano tonyanziano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justinwilaby @coveralls @tonyanziano