Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show message when nothing has been inspected yet #1290

Merged
merged 2 commits into from Feb 1, 2019

Conversation

3 participants
@a-b-r-o-w-n
Copy link
Contributor

a-b-r-o-w-n commented Feb 1, 2019

closes #1127
closes #1223

Added

  • [client] Show a message when nothing has been inspected yet, in PR #1290

image

@a-b-r-o-w-n a-b-r-o-w-n added the 4.3 label Feb 1, 2019

@a-b-r-o-w-n a-b-r-o-w-n added this to Review in 4.3 Prioritization via automation Feb 1, 2019

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 1, 2019

Pull Request Test Coverage Report for Build 1970

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 50.381%

Totals Coverage Status
Change from base Build 1968: 0.08%
Covered Lines: 4511
Relevant Lines: 8353

💛 - Coveralls
@tonyanziano
Copy link
Contributor

tonyanziano left a comment

Awesome! This also fixes #1223 which I was going down the rabbit hole with. The check for state.inspectObj is a much nicer fix!

@a-b-r-o-w-n

This comment has been minimized.

Copy link
Contributor Author

a-b-r-o-w-n commented Feb 1, 2019

@tonyanziano oh nice. I didn't test that but I will.

@tonyanziano

This comment has been minimized.

Copy link
Contributor

tonyanziano commented Feb 1, 2019

I just copied your Inspector.tsx changes over and tested it, and it looks like it resolves it. 👍

@a-b-r-o-w-n a-b-r-o-w-n merged commit 7c05e44 into Microsoft:master Feb 1, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.08%) to 50.381%
Details
license/cla All CLA requirements met.
Details

4.3 Prioritization automation moved this from Review to Done Feb 1, 2019

@a-b-r-o-w-n a-b-r-o-w-n deleted the a-b-r-o-w-n:empty-inspector-message branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.