Implemented '/INSPECT open' command when connecting to a debug bot vi… #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten and
justinwilaby
as code owners
justinwilaby
suggested changes
Apr 29, 2019
| activity | ||
| ); | ||
| if (postActivityResponse.statusCode >= 400) { | ||
| throw new Error(`An error occurred while POSTing "/INSPECT open" command to conversation ${conversationId}`); |
There was a problem hiding this comment.
Because saga exceptions aren't the greatest when it comes to capturing, I think we should dispatch a notification with the error message instead of throwing.
There was a problem hiding this comment.
The whole thing is inside of a try-catch that does exactly that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…a url.
===
One of #1443