Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Conversation: send a single conversation update activity including bot and user as members added #1709

Merged
merged 2 commits into from Aug 7, 2019
Merged

New Conversation: send a single conversation update activity including bot and user as members added #1709

merged 2 commits into from Aug 7, 2019

Conversation

carlosscastro
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Aug 7, 2019 •
edited

Coverage Status

Coverage decreased (-0.02%) to 62.91% when pulling 83be3d3 on ccastro/aggregated-conversation-update into 35635ea on master.

tonyanziano
tonyanziano reviewed Aug 7, 2019
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this same logic needs to be applied to the /v3/directline/conversations route as well.

Source can be found here.

===

I'm still not entirely sure which route gets hit when.

@tonyanziano
Copy link
Contributor

Needs a CHANGELOG.md entry as well.

@carlosscastro
Copy link
Member Author

Thanks @tonyanziano I'll make those updates

tonyanziano
tonyanziano approved these changes Aug 7, 2019
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 👍

@tonyanziano tonyanziano merged commit 54e8cbe into master Aug 7, 2019
@tonyanziano tonyanziano deleted the ccastro/aggregated-conversation-update branch August 7, 2019 23:44
@tonyanziano tonyanziano mentioned this pull request Aug 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyanziano tonyanziano tonyanziano approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@compulim compulim Awaiting requested review from compulim

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carlosscastro @coveralls @tonyanziano