Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#1817][MAS1.3.3] [Visual Requirements-Debug] Tool tips are not defined for “Previous, Next and Show diff” controls #1852

Merged
merged 6 commits into from Sep 11, 2019

Conversation

denscollo
Copy link
Contributor

Solves #1817

Description

The tooltips for arrows and hide-show buttons weren't showing.

Changes made

  • Tooltips for arrows and hide-show buttons

Testing

tooltips in previous, next and hide show diff

@coveralls
Copy link

coveralls commented Sep 9, 2019

Coverage Status

Coverage remained the same at 65.787% when pulling ca3699c on fix/tooltips-for-arrows-and-hide-show-buttons into f034cbc on master.

@tonyanziano
Copy link
Contributor

I think a tooltip should be added to the "Copy json" button as well, just to preemptively knock out that accessibility issue.

Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@tonyanziano tonyanziano merged commit 22f5958 into master Sep 11, 2019
@tonyanziano tonyanziano deleted the fix/tooltips-for-arrows-and-hide-show-buttons branch September 11, 2019 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants