Convert all links/link-like-buttons to <LinkButton> #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corinagum
requested review from
a-b-r-o-w-n,
compulim and
cwhitten
as code owners
tonyanziano
suggested changes
Sep 24, 2019
packages/app/client/src/ui/dialogs/connectServicePromptDialog/connectServicePromptDialog.tsx
Outdated
Show resolved
Hide resolved
packages/app/client/src/ui/dialogs/dataCollectionDialog/dataCollectionDialog.tsx
Outdated
Show resolved
Hide resolved
packages/app/client/src/ui/dialogs/getStartedWithCSDialog/getStartedWithCSDialog.tsx
Outdated
Show resolved
Hide resolved
packages/app/client/src/ui/dialogs/getStartedWithCSDialog/getStartedWithCSDialog.tsx
Outdated
Show resolved
Hide resolved
packages/app/client/src/ui/shell/explorer/servicesExplorer/servicesExplorer.scss
Outdated
Show resolved
Hide resolved
...ent/src/ui/shell/explorer/servicesExplorer/connectedServiceEditor/connectedServiceEditor.tsx
Show resolved
Hide resolved
|
Coverage also dropped 0.4%. This needs tests, half a percent is pretty huge |
tonyanziano
suggested changes
Sep 26, 2019
packages/app/client/src/ui/dialogs/botCreationDialog/botCreationDialog.tsx
Outdated
Show resolved
Hide resolved
packages/app/client/src/ui/dialogs/botSettingsEditor/botSettingsEditor.spec.tsx
Outdated
Show resolved
Hide resolved
| @@ -102,4 +117,11 @@ describe('The ConnectServicePromptDialog component should', () => { | |||
| instance.props.addServiceManually(); | |||
| expect(spy).toHaveBeenCalledWith(2); | |||
| }); | |||
|
|
|||
| it('should call the appropriate command when onAnchorClick is called', async () => { | |||
| @@ -64,4 +71,11 @@ describe('<DataCollectionDialogContainer />', () => { | |||
|
|
|||
| expect(hideDialogSpy).toHaveBeenCalledWith(true); | |||
| }); | |||
|
|
|||
| it('should call the appropriate command when onAnchorClick is called', async () => { | |||
| @@ -196,4 +200,18 @@ describe('The GetStartedWithCSDialog component should', () => { | |||
| const prompt = parent.find(GetStartedWithCSDialog); | |||
| expect(prompt.instance().content).toBeNull(); | |||
| }); | |||
|
|
|||
| it('should call the appropriate command when onAnchorClick is called', async () => { | |||
...ges/app/client/src/ui/shell/explorer/endpointExplorer/endpointEditor/endpointEditor.spec.tsx
Outdated
Show resolved
Hide resolved
packages/app/client/src/ui/editor/emulator/parts/inspector/inspector.spec.tsx
Outdated
Show resolved
Hide resolved
...rc/ui/shell/explorer/servicesExplorer/connectedServiceEditor/connectedServiceEditor.spec.tsx
Outdated
Show resolved
Hide resolved
...rc/ui/shell/explorer/servicesExplorer/connectedServicePicker/connectedServicePicker.spec.tsx
Outdated
Show resolved
Hide resolved
packages/app/client/src/ui/shell/explorer/servicesExplorer/servicesExplorer.spec.tsx
Outdated
Show resolved
Hide resolved
…ulator into corinagum/1825
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1712, #1806, #1825
This PR fixes the roles of all buttons and links that look like links (See above: blue text is our example)
There shouldn't be any visual changes, this is a semantics / tests update. Dialog/explorer links will be the darker blue, while pages will be the default blue.
@tonyanziano, sorry for the ginoromous PR.