[ISSUE#1896][MAS1.3.1][Screen Reader-Connect the bot] Incorrect position of the controls are announced by voiceover for the buttons available at the top most menu bar.

[denscollo]

Solves #1896

Description

Fixes how voiceover announces the position of the editor menu bar's buttons controls

Changes made

We added an aria-hidden attribute to the separator bar between the restart conversation button and the sub-menu button. This way voiceover skips this element which was causing the problem.

Additionally, we noticed that in windows, the last element of the menu bar was not being announced as 3/3. To solve this we removed a div around the save transcript button and moved the role label menuitem inside it.

Testing

In the next image, you can see the voiceover reading the order of the elements as intended.

[coveralls]

Coverage remained the same at 66.949% when pulling b1c0239 on fix/incorrect-position-announced into 2717295 on master.

[tonyanziano]

Looks good to me. Add a changelog entry to CHANGELOG.md and I'll merge it in. :)

[denscollo]

Thanks @tonyanziano ! I justed pushed the updated changelog