This repository was archived by the owner on Jan 5, 2026. It is now read-only.
[ISSUE#1896][MAS1.3.1][Screen Reader-Connect the bot] Incorrect position of the controls are announced by voiceover for the buttons available at the top most menu bar.#1935
Merged
Conversation
denscollo
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten and
tonyanziano
as code owners
tonyanziano
previously approved these changes
Oct 22, 2019
Contributor
tonyanziano
left a comment
tonyanziano
left a comment
There was a problem hiding this comment.
Looks good to me. Add a changelog entry to CHANGELOG.md and I'll merge it in. :)
Contributor
Author
|
Thanks @tonyanziano ! I justed pushed the updated changelog |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #1896
Description
Fixes how voiceover announces the position of the editor menu bar's buttons controls
Changes made
We added an
aria-hiddenattribute to the separator bar between therestart conversationbutton and the sub-menu button. This way voiceover skips this element which was causing the problem.Additionally, we noticed that in windows, the last element of the menu bar was not being announced as 3/3. To solve this we removed a
divaround thesave transcriptbutton and moved the role labelmenuiteminside it.Testing
In the next image, you can see the voiceover reading the order of the elements as intended.