Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#1896][MAS1.3.1][Screen Reader-Connect the bot] Incorrect position of the controls are announced by voiceover for the buttons available at the top most menu bar. #1935

Merged
merged 3 commits into from Oct 22, 2019

Conversation

@denscollo
Copy link
Collaborator

denscollo commented Oct 21, 2019

Solves #1896

Description

Fixes how voiceover announces the position of the editor menu bar's buttons controls

Changes made

We added an aria-hidden attribute to the separator bar between the restart conversation button and the sub-menu button. This way voiceover skips this element which was causing the problem.

Additionally, we noticed that in windows, the last element of the menu bar was not being announced as 3/3. To solve this we removed a div around the save transcript button and moved the role label menuitem inside it.

Testing

In the next image, you can see the voiceover reading the order of the elements as intended.

asda

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 21, 2019

Coverage Status

Coverage remained the same at 66.949% when pulling b1c0239 on fix/incorrect-position-announced into 2717295 on master.

Copy link
Contributor

tonyanziano left a comment

Looks good to me. Add a changelog entry to CHANGELOG.md and I'll merge it in. :)

@denscollo

This comment has been minimized.

Copy link
Collaborator Author

denscollo commented Oct 22, 2019

Thanks @tonyanziano ! I justed pushed the updated changelog

@tonyanziano tonyanziano merged commit ffa96e8 into master Oct 22, 2019
1 of 2 checks passed
1 of 2 checks passed
Emulator-CI-PR in progress
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the fix/incorrect-position-announced branch Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.