[#1979] Fixed app menu tab navigation issue on Linux. #2022

tonyanziano · 2019-12-10T23:19:53Z

===

Actually fixing it this time 😅
When the tab focus logic was running it was only looking inside the nav bar for the first focusable element, when it actually needs to look in the app menu on Linux

Video of it working:

coveralls · 2019-12-10T23:33:39Z

Coverage increased (+0.009%) to 68.768% when pulling d1806fa on toanzian/acc-#1979 into 7e922ad on master.

cwhitten · 2019-12-10T23:36:35Z

packages/app/client/src/utils/eventHandlers.ts


      if (tabPressed) {
+        const lastDecendants = EventHandlers.getLastDecendants(document.querySelector('main'));


the only other way I've done this is with document.querySelectorAll and slicing the resulting array up.

Fixed app menu tab navigation issue on Linux.

d1806fa

tonyanziano requested review from a-b-r-o-w-n, compulim, corinagum and cwhitten as code owners December 10, 2019 23:19

cwhitten reviewed Dec 10, 2019

View reviewed changes

cwhitten approved these changes Dec 10, 2019

View reviewed changes

tonyanziano merged commit c536dec into master Dec 10, 2019

tonyanziano deleted the toanzian/acc-#1979 branch December 10, 2019 23:43

Provide feedback


		if (tabPressed) {
		const lastDecendants = EventHandlers.getLastDecendants(document.querySelector('main'));